feat: add dismissible privacy banner#836
Conversation
|
@srinidhi-2006-bit is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
👋 Thanks for your PR, @srinidhi-2006-bit!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
✅ PR Format Check Passed — @srinidhi-2006-bitBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
|
Hey @srinidhi-2006-bit! The 1. Footer removed from 2. Accessibility attributes removed from <main id="main-content" tabIndex={-1} className="flex-1">Fix those two and the PR is ready to merge! |
|
Hey @srinidhi-2006-bit! Thanks for adding the privacy banner — it's a nice feature. However this PR has a few structural issues with Issues in page.tsx:
What to fix: <main id="main-content" tabIndex={-1}>
<PrivacyBanner />
<VideoEditor />
</main>The |
9c2aebc to
9adf619
Compare
|
Thanks for the review! I restored the original page structure, brought back the The build, lint, and type checks are now passing successfully. Before merging the PR, could you please add the |
Description
Added a dismissible privacy advantage banner above the upload/editor section to highlight that Reframe processes videos fully in-browser using FFmpeg.wasm without uploading files to any server.
Related Issue
Closes #679
Type of Contribution
Participant Info
Screen Recording
Recording demonstrates:
Recording / Loom link:
screen-recording-2026-05-21-105259_xPsdiBm1.mp4
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in