Skip to content

feat: export success sound with mute toggle #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pranav-IIITM wants to merge 1 commit into
base: main
Choose a base branch
from
+30 −12
Open

feat: export success sound with mute toggle #706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 23 additions & 11 deletions src/components/DownloadResult.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import { useState, useEffect } from "react";
import { ExportResult } from "@/lib/types";
import { formatBytes } from "@/lib/utils";
import { Download, RotateCcw, Share2, AlertCircle } from "lucide-react";
import { Download, RotateCcw, Share2, AlertCircle, Volume2, VolumeX } from "lucide-react";
import LottiePlayer from "./LottiePlayer";
import successAnim from "@/lib/lottie/success.json";
import { cn } from "@/lib/utils";
Expand All @@ -15,9 +15,10 @@ interface Props {
result: ExportResult;
onReset: () => void;
soundOnCompletion: boolean;
onToggleSound: () => void;
}

export default function DownloadResult({ result, onReset, soundOnCompletion }: Props) {
export default function DownloadResult({ result, onReset, soundOnCompletion, onToggleSound }: Props) {
const defaultName = `reframe_${result.width}x${result.height}`;
const [name, setName] = useState(defaultName);

Expand All @@ -41,15 +42,26 @@ export default function DownloadResult({ result, onReset, soundOnCompletion }: P

return (
<div className="p-5 bg-[var(--surface)] border border-[var(--border)] rounded-xl space-y-4">
<div className="flex items-center gap-4">
<div className="w-12 h-12 shrink-0">
<LottiePlayer animationData={successAnim} loop={false} autoplay />
</div>
<div>
<p className="font-heading font-bold text-base text-[var(--text)]">Export complete</p>
<p className="text-xs text-[var(--muted)] mt-0.5">Ready to download</p>
</div>
</div>
<div className="flex items-center justify-between">
<div className="flex items-center gap-4">
<div className="w-12 h-12 shrink-0">
<LottiePlayer animationData={successAnim} loop={false} autoplay />
</div>
<div>
<p className="font-heading font-bold text-base text-[var(--text)]">Export complete</p>
<p className="text-xs text-[var(--muted)] mt-0.5">Ready to download</p>
</div>
</div>
<button
type="button"
onClick={onToggleSound}
aria-label={soundOnCompletion ? "Mute completion sound" : "Unmute completion sound"}
className="p-2 rounded-lg border border-[var(--border)] text-[var(--muted)] hover:bg-[var(--bg)] transition-colors"
title={soundOnCompletion ? "Sound on" : "Sound off"}
>
{soundOnCompletion ? <Volume2 size={14} /> : <VolumeX size={14} />}
</button>
</div>

<div className="grid grid-cols-2 gap-2 text-sm">
<div className="bg-[var(--bg)] rounded-lg p-3 border border-[var(--border)]">
Expand Down
3 changes: 2 additions & 1 deletion src/components/VideoEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export default function VideoEditor() {
overlaySize, setOverlaySize,
overlayOpacity, setOverlayOpacity,
recommendedPreset,
toggleSound,
} = useVideoEditor();
const [copied, setCopied] = useState(false);
const downloadRef = useRef<HTMLDivElement>(null);
Expand Down Expand Up @@ -305,7 +306,7 @@ export default function VideoEditor() {

{status === "done" && result && (
<div role="status" className="animate-fade-in" ref={downloadRef}>
<DownloadResult result={result} onReset={reset} soundOnCompletion={recipe.soundOnCompletion} />
<DownloadResult result={result} onReset={reset} soundOnCompletion={recipe.soundOnCompletion} onToggleSound={toggleSound} />
</div>
)}
</div>
Expand Down
5 changes: 5 additions & 0 deletions src/hooks/useVideoEditor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,10 @@ export function useVideoEditor() {
}
}, []);

const toggleSound = useCallback(() => {
updateRecipe({ soundOnCompletion: !recipe.soundOnCompletion });
}, [recipe.soundOnCompletion, updateRecipe]);

return {
file,
duration,
Expand Down Expand Up @@ -472,5 +476,6 @@ export function useVideoEditor() {
overlayOpacity,
setOverlayOpacity,
recommendedPreset,
toggleSound,
};
}
Loading