feat: export success sound with mute toggle#706
Open
Pranav-IIITM wants to merge 1 commit into
Open
Conversation
Closes magic-peach#681 Changes: - Play export-complete.mp3 when export finishes - Add mute toggle button (Volume2/VolumeX) in the export result card - Persist mute preference in localStorage via soundOnCompletion in recipe Files modified: - src/components/DownloadResult.tsx - src/hooks/useVideoEditor.ts - src/components/VideoEditor.tsx
|
@Pranav-IIITM is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
👋 Thanks for your PR, @Pranav-IIITM!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Contributor
✅ PR Format Check Passed — @Pranav-IIITMBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
github-actions
Bot
added
level:beginner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements export success sound and mute toggle as described in #681. When export completes, a short chime plays and a mute toggle button appears in the result card. The preference is saved in localStorage.
Related Issue
Closes #681
Type of Contribution
Participant Info
Screen Recording
To see the result see 00:17
Demo.mp4
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in