Skip to content

feat : added a trim controller #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AarishMansur wants to merge 4 commits into
base: main
Choose a base branch
from
+113 −12
Open

feat : added a trim controller #702

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba5ecd1
added a trim controller
AarishMansur May 19, 2026
c93e1d3
fix(trim): change role to toolbar to satisfy jsx-a11y lint rule
AarishMansur May 19, 2026
2c91d0f
Merge branch 'main' into feat/timeline-trim-scrubber-v2
AarishMansur May 20, 2026
9757af1
ci: trigger CI rerun
AarishMansur May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 113 additions & 12 deletions src/components/TrimControl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"use client";

import { EditRecipe } from "@/lib/types";
import { useState, useEffect } from "react";
import { useState, useEffect, useRef, useCallback } from "react";
import { AlertCircle } from "lucide-react";
import { formatDuration } from "@/lib/utils";

Expand All @@ -16,13 +16,56 @@ export default function TrimControl({ recipe, onChange, duration }: Props) {
const [invalidEnd, setEnd] = useState(false);
const [startErrorMsg, setStartErrorMsg] = useState("");
const [endErrorMsg, setEndErrorMsg] = useState("");
const [startInput, setStartInput] = useState(recipe.trimStart.toString());
const [startInput, setStartInput] = useState(
recipe.trimStart.toString()
);

useEffect(() => {
setStartInput(recipe.trimStart.toString());
}, [recipe.trimStart]);

const clipLength = (recipe.trimEnd ?? duration) - recipe.trimStart;
const clipLength =
(recipe.trimEnd ?? duration) - recipe.trimStart;

const trackRef = useRef<HTMLDivElement>(null);
const dragging = useRef<"start" | "end" | null>(null);

const xToSeconds = useCallback((clientX: number) => {
const track = trackRef.current;
if (!track || duration <= 0) return 0;
const { left, width } = track.getBoundingClientRect();
const ratio = Math.max(0, Math.min(1, (clientX - left) / width));
return parseFloat((ratio * duration).toFixed(1));
}, [duration]);

const applyDrag = useCallback((clientX: number) => {
const seconds = xToSeconds(clientX);
if (dragging.current === "start") {
const clamped = Math.min(seconds, (recipe.trimEnd ?? duration) - 0.1);
onChange({ trimStart: Math.max(0, clamped) });
} else if (dragging.current === "end") {
const clamped = Math.max(seconds, recipe.trimStart + 0.1);
onChange({ trimEnd: Math.min(duration, clamped) });
}
}, [xToSeconds, duration, recipe.trimStart, recipe.trimEnd, onChange]);

useEffect(() => {
const onMove = (e: MouseEvent | TouchEvent) => {
const clientX = "touches" in e ? e.touches[0].clientX : e.clientX;
applyDrag(clientX);
};
const onUp = () => { dragging.current = null; };
document.addEventListener("mousemove", onMove);
document.addEventListener("mouseup", onUp);
document.addEventListener("touchmove", onMove);
document.addEventListener("touchend", onUp);
return () => {
document.removeEventListener("mousemove", onMove);
document.removeEventListener("mouseup", onUp);
document.removeEventListener("touchmove", onMove);
document.removeEventListener("touchend", onUp);
};
}, [applyDrag]);

const handleStart = (val: string) => {
setStartInput(val);
Expand Down Expand Up @@ -50,7 +93,7 @@ export default function TrimControl({ recipe, onChange, duration }: Props) {
if (duration > 0 && n >= duration) {
setStart(true);
setStartErrorMsg(
`Start time must be less than duration (${duration.toFixed(1)}s).`,
`Start time must be less than duration (${duration.toFixed(1)}s).`
);
return;
}
Expand Down Expand Up @@ -113,6 +156,64 @@ export default function TrimControl({ recipe, onChange, duration }: Props) {

return (
<div id="trim-control" className="space-y-3">
{duration > 0 && (
<div
role="toolbar"
aria-label="Trim timeline"
ref={trackRef}
className="relative h-6 flex items-center cursor-pointer select-none"
onClick={(e) => {
if (dragging.current) return;
const s = xToSeconds(e.clientX);
onChange({ trimStart: s });
}}
onKeyDown={(e) => {
if (e.key === "ArrowLeft") onChange({ trimStart: Math.max(0, recipe.trimStart - 0.1) });
if (e.key === "ArrowRight") onChange({ trimStart: Math.min((recipe.trimEnd ?? duration) - 0.1, recipe.trimStart + 0.1) });
}}
>
<div className="absolute inset-x-0 h-1.5 rounded-full bg-[var(--border)]" />
<div
className="absolute h-1.5 rounded-full bg-film-400 opacity-60"
style={{
left: `${(recipe.trimStart / duration) * 100}%`,
right: `${((duration - (recipe.trimEnd ?? duration)) / duration) * 100}%`,
}}
/>
<div
role="slider"
aria-label="Trim start"
aria-valuenow={recipe.trimStart}
aria-valuemin={0}
aria-valuemax={duration}
tabIndex={0}
className="absolute w-4 h-4 rounded-full bg-white border-2 border-film-400 shadow cursor-grab active:cursor-grabbing -translate-x-1/2 focus:outline-none focus:ring-2 focus:ring-film-400"
style={{ left: `${(recipe.trimStart / duration) * 100}%` }}
onMouseDown={() => { dragging.current = "start"; }}
onTouchStart={() => { dragging.current = "start"; }}
onKeyDown={(e) => {
if (e.key === "ArrowLeft") onChange({ trimStart: Math.max(0, recipe.trimStart - 0.1) });
if (e.key === "ArrowRight") onChange({ trimStart: Math.min((recipe.trimEnd ?? duration) - 0.1, recipe.trimStart + 0.1) });
}}
/>
<div
role="slider"
aria-label="Trim end"
aria-valuenow={recipe.trimEnd ?? duration}
aria-valuemin={0}
aria-valuemax={duration}
tabIndex={0}
className="absolute w-4 h-4 rounded-full bg-white border-2 border-film-400 shadow cursor-grab active:cursor-grabbing -translate-x-1/2 focus:outline-none focus:ring-2 focus:ring-film-400"
style={{ left: `${((recipe.trimEnd ?? duration) / duration) * 100}%` }}
onMouseDown={() => { dragging.current = "end"; }}
onTouchStart={() => { dragging.current = "end"; }}
onKeyDown={(e) => {
if (e.key === "ArrowLeft") onChange({ trimEnd: Math.max(recipe.trimStart + 0.1, (recipe.trimEnd ?? duration) - 0.1) });
if (e.key === "ArrowRight") onChange({ trimEnd: Math.min(duration, (recipe.trimEnd ?? duration) + 0.1) });
}}
/>
</div>
)}
<div className="flex gap-3">
<div className="flex-1">
<label
Expand All @@ -134,9 +235,7 @@ export default function TrimControl({ recipe, onChange, duration }: Props) {
aria-label="Trim start time in seconds"
aria-invalid={invalidStart}
aria-describedby={invalidStart ? "trim-start-error" : undefined}
className={`${inputClass} ${
invalidStart ? "border-red-500" : "border-[var(--border)]"
}`}
className={`${inputClass} ${invalidStart ? "border-red-500 focus:ring-red-400" : "border-[var(--border)]"}`}
placeholder="0"
/>
{invalidStart && (
Expand Down Expand Up @@ -169,10 +268,9 @@ export default function TrimControl({ recipe, onChange, duration }: Props) {
onChange={(e) => handleEnd(e.target.value)}
aria-label="Trim end time in seconds"
aria-invalid={invalidEnd}
className={`${inputClass} ${invalidEnd ? "border-red-500" : "border-[var(--border)]"}`}
placeholder={
duration > 0 ? `${duration.toFixed(1)}` : "full length"
}
aria-describedby={invalidEnd ? "trim-end-error" : undefined}
className={`${inputClass} ${invalidEnd ? "border-red-500 focus:ring-red-400" : "border-[var(--border)]"}`}
placeholder={duration > 0 ? `${duration.toFixed(1)}` : "full length"}
/>
{invalidEnd && (
<p
Expand All @@ -188,9 +286,12 @@ export default function TrimControl({ recipe, onChange, duration }: Props) {

{duration > 0 && (
<p className="text-sm text-[var(--muted)] font-heading mt-1">
Clip: {formatDuration(clipLength)} of {formatDuration(duration)}
Clip: {formatDuration(clipLength)} of{" "}
{formatDuration(duration)}
</p>
)}
</div>
);
}


Loading