Skip to content

feat : added a trim controller#702

Open
AarishMansur wants to merge 2 commits into
magic-peach:mainfrom
AarishMansur:feat/timeline-trim-scrubber-v2
Open

feat : added a trim controller#702
AarishMansur wants to merge 2 commits into
magic-peach:mainfrom
AarishMansur:feat/timeline-trim-scrubber-v2

Conversation

@AarishMansur
Copy link
Copy Markdown
Contributor

Description

Replaced the static number inputs in TrimControl.tsx with an interactive timeline scrubber. Users can now drag handles to set trim start/end instead of typing seconds manually. Number inputs remain below for fine-tuning and stay in sync with the scrubber.

Related Issue

Closes #666

Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • GSSoC contribution

Participant Info

  • GitHub username: aarishmansur
  • Contribution level (Beginner/Intermediate/Advanced): Advanced

Screen Recording

cursorful-video-1779170924149.mp4

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue
  • Screen recording attached above (required for UI/feature/design changes)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 19, 2026

@AarishMansur is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added level:intermediate Intermediate level - 35 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature labels May 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

⚠️ PR Format Issues — @AarishMansur

Please fix the following before your PR can be reviewed:

  • ⚠️ Use a conventional PR title. Examples:
    • feat: add dark mode support
    • fix: resolve aria label missing on slider
    • docs: add deployment guide to README

Push new commits after fixing — this comment will update automatically.

📖 CONTRIBUTING.md

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @AarishMansur!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added the gssoc'26 GirlScript Summer of Code 2026 label May 19, 2026
@AarishMansur AarishMansur changed the title added a trim controller feat : added a trim controller May 19, 2026
@AarishMansur
Copy link
Copy Markdown
Contributor Author

@magic-peach added and now cl tests are passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:intermediate Intermediate level - 35 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: drag-and-drop timeline trim markers — replace number inputs with an interactive scrubber

1 participant