fix(email): drop leftover-canvas CSS zoom - #6374
cameronapak wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (11)
💤 Files with no reviewable changes (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe email renderer no longer applies fit-to-width zoom. It keeps content at native size and enables horizontal scrolling for wide expanded content. Email body hosts now use zero minimum width and full width. Browser tests and fixture descriptions reflect native-size scrolling. Documentation records email client fitting mechanisms and Zero's wrap-or-scroll behavior. Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The email pane retains native-size wide content with horizontal scrolling, while narrow content remains constrained to the pane. No unresolved merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hey @peterchinman, this PR comes from when you mentioned the idea of completely removing the email contents odd CSS zoom approach entirely. I wanted to ask if you'd be willing to take this PR the rest of the way to merge. It feels like it's done and ready for merge, but I want to make sure that it meets your quality checks and for your eyes just in case I may be missing something |
Why
PR #5926 could not run Macro's credentialed pipelines because its head branch lived on a personal fork. It also stacked on #5890, which has since merged.
The remaining behavior change is still useful: leftover CSS
zoomshrinks wide designed email and its text. Constrained content should wrap, while genuinely wide layouts should remain at native size and scroll horizontally.What changed
This replaces #5926 with a
macro-inc/macrohead branch and applies the intended change to the current email-renderer architecture.Validation
just check<pre>, signatures, and quotes stay within 240px at nativezoom: 1zoom: 1, wrapped<pre>, and no horizontal overflow