fix(email): drop leftover-canvas CSS zoom - #5926
Closed
cameronapak wants to merge 12 commits into
Closed
cameronapak wants to merge 12 commits into
cameronapak wants to merge 12 commits into
Conversation
Unbounded pane/content zoom made GitHub review mail unreadably small. Contain pre/code first, then scale leftover newsletter canvases no lower than 0.7. Co-authored-by: Cursor <cursoragent@cursor.com>
Needed so local fixtures can store real sanitized HTML instead of wrapping plaintext in a paragraph. Co-authored-by: Cursor <cursoragent@cursor.com>
Reviewers can see the GitHub-mail zoom bug next to the wrap-and-floor fix. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep the viewer and seed commits; drop the PNGs from the tree. Co-authored-by: Cursor <cursoragent@cursor.com>
Agents could not find the Playwright suite from the repo root, and it would not have caught unbounded zoom on unwrapped review diffs. Co-authored-by: Cursor <cursoragent@cursor.com>
Scenario apply wrote body_html straight into body_html_sanitized. That column is supposed to go through sanitize_email_html. Co-authored-by: Cursor <cursoragent@cursor.com>
The harness zoomed the padded page container, so it could not prove the 0.7 floor. Mount the same shadow message node and snapshot an 836px table at 360 and 800. Co-authored-by: Cursor <cursoragent@cursor.com>
Clearing the overflow shorthand does not drop a prior overflowX auto, so a later fitting resize could keep a scrollbar. Co-authored-by: Cursor <cursoragent@cursor.com>
Claude Code reads CLAUDE.md. The @AGENTS.md import loads the shared web agent file. Snapshot recipes belong there with the other bun commands. Co-authored-by: Cursor <cursoragent@cursor.com>
CI failed because the zoom helper and its tests used a wrap Biome rejects. Co-authored-by: Cursor <cursoragent@cursor.com>
Wide designed tables stay at native type and scroll. Wrap and containment stay. Client comparison lives with this follow-up. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Wide tables grew the host to min-content after zoom was dropped, so overflow-x never applied and ancestors clipped the letter. Co-authored-by: Cursor <cursoragent@cursor.com>
8 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zoomis gone. Wide designed tables stay at native type and scroll sideways.pre/codewrap like Gmail.apps/web/docs/email-client-zoom.md.Test plan
just test-email-renderingfrom the repo rootmax-width: 100%on all tablesMade with Cursor