Skip to content

Add use_firehose option & configuration conflit #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dopch wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add use_firehose option & configuration conflit #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
028b028
Add use_firehose ,configuration conflit
dopch Nov 25, 2015
d8d9a8e
Edit lib/logstash/inputs/twitter.rb ConfigurationError reply (jordans…
dopch Dec 10, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion lib/logstash/inputs/twitter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,9 @@ class LogStash::Inputs::Twitter < LogStash::Inputs::Base
# follows, locations, and languages options will be ignored. Default => false
config :use_samples, :validate => :boolean, :default => false

# Returns all tweet from firehose
config :use_firehose, :validate => :boolean, :default => false

# Lets you ingore the retweets coming out of the Twitter API. Default => false
config :ignore_retweets, :validate => :boolean, :default => false

Expand All @@ -101,10 +104,14 @@ class LogStash::Inputs::Twitter < LogStash::Inputs::Base
def register
require "twitter"

if !@use_samples && ( @keywords.nil? && @follows.nil? && @locations.nil? )
if !@use_samples && !@use_firehose && ( @keywords.nil? && @follows.nil? && @locations.nil? )
raise LogStash::ConfigurationError.new("At least one parameter (follows, locations or keywords) must be specified.")
end

if @use_samples && @use_firehose
raise LogStash::ConfigurationError.new("use_firehose and use_samples cannot both be true")
end

# monkey patch twitter gem to ignore json parsing error.
# at the same time, use our own json parser
# this has been tested with a specific gem version, raise if not the same
Expand All @@ -124,6 +131,11 @@ def run(queue)
return if stop?
tweet_processor(queue, tweet)
end
elsif @use_firehose
@stream_client.firehose do |tweet|
return if stop?
tweet_processor(queue, tweet)
end
else
@stream_client.filter(twitter_options) do |tweet|
return if stop?
Expand Down