Add use_firehose option & configuration conflit#34
Open
dopch wants to merge 2 commits into
Open
Conversation
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
Contributor
|
jenkins, test it |
Contributor
There was a problem hiding this comment.
Typo on choose - maybe rephrase "use_firehose and use_samples cannot both be true. Choose one or the other." ?
Contributor
|
Code change looks OK to me. I don't have access to the twitter firehose so I'm not sure how to test this new change. I left one small comment on the validation error. Back to you to respond - otherwise this change looks good to me! :) |
Author
|
you can try the method Twitter firehose send your a reply "Unauthorized" , I change the validation error =) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.