Skip to content

fix(workflows): return typed task admission responses #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gansx merged 2 commits into from
Nov 1, 2026
Merged

fix(workflows): return typed task admission responses #629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89cf8ff
fix(workflows): return typed task admission responses
Nov 1, 2026
1c83cbd
fix(contracts): type workflow admission discriminators
Nov 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/contracts/src/workflows.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1396,6 +1396,8 @@ export interface ChannelWorkflowStepMutationResponse {
}

export interface ChannelWorkflowStepStartResponse {
readonly status: "started" | "blocked";
readonly mode: ChannelWorkflowStepStartMode;
readonly workflowStep: ChannelWorkflowStep;
readonly workflow?: ChannelWorkflow;
readonly task?: Task;
Expand Down
4 changes: 4 additions & 0 deletions packages/daemon/src/features/channels/workflows.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,6 +629,8 @@ async function handleChannelWorkflowStepStart(
const started = await prepareWorkflowStepStart(store, workflowStepId, input, cwd, validateRunRequest, secretResolver);
if (started.kind === "blocked") {
writeJson(response, 200, {
status: "blocked",
mode: input.mode,
workflow: store.getChannelWorkflow(started.workflowId),
workflowStep: store.getChannelWorkflowStep(workflowStepId),
blocker: started.blocker,
Expand All @@ -651,6 +653,8 @@ async function handleChannelWorkflowStepStart(
}
completeWorkflowIfStepsFinished(store, started.workflowId, finishedAt);
writeJson(response, 200, {
status: "started",
mode: "create_task",
Comment thread
gansx marked this conversation as resolved.
Resolved
workflow: store.getChannelWorkflow(started.workflowId),
workflowStep: store.getChannelWorkflowStep(workflowStepId),
task: started.task,
Expand Down
4 changes: 4 additions & 0 deletions packages/daemon/test/channel-workspace.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9351,6 +9351,8 @@ test("channel handoff workflows start steps, create tasks, and expose blockers",
mode: "create_task",
taskTitle: "Workflow generated task",
});
assert.equal(started.status, "started");
assert.equal(started.mode, "create_task");
assert.equal(started.workflow.status, "succeeded");
assert.equal(started.workflowStep.status, "succeeded");
assert.equal(started.task.title, "Workflow generated task");
Expand Down Expand Up @@ -9379,6 +9381,8 @@ test("channel handoff workflows start steps, create tasks, and expose blockers",
const blocked = await postJson(`${daemon.url}/workflow-steps/${encodeURIComponent(blockedWorkflow.workflowStep.id)}/start?cwd=${encodeURIComponent(cwd)}`, {
mode: "create_and_run_task",
});
assert.equal(blocked.status, "blocked");
assert.equal(blocked.mode, "create_and_run_task");
assert.equal(blocked.workflowStep.status, "blocked");
assert.match(blocked.blocker, /provider preset/i);

Expand Down
Loading