Skip to content

fix(workflows): return typed task admission responses - #629

Merged
gansx merged 2 commits into
mainfrom
gansx/fix-workflow-admission-response
Nov 1, 2026
Merged

gansx merged 2 commits into
mainfrom
gansx/fix-workflow-admission-response

Conversation

@gansx

@gansx gansx commented Nov 1, 2026

Copy link
Copy Markdown
Collaborator

Problem

The channel workflow step start endpoint returned an untyped JSON shape for both successful create_task starts and blocked admissions. The web client validates status and mode, so a server-created task could be rejected as an invalid response and a valid blocker could be dropped.

Fix

  • Return status: "started" and mode: "create_task" for successful task creation.
  • Return status: "blocked" and the requested mode for blocked admissions.
  • Add daemon regression assertions for both response shapes.

Validation

  • Daemon workflow endpoint regression: passed.
  • Contracts and web workflow admission tests: 15/15 passed.
  • TypeScript builds for contracts, API client, core dependencies, and daemon: passed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T06:58:26.285063Z 89cf8ff PR opened
🔒 Security Review ✅ Completed 2026-11-01T09:17:21.482420Z 1c83cbd New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 89cf8ff7a7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@gansx
gansx merged commit 63bc332 into main Nov 1, 2026
15 checks passed
@gansx
gansx deleted the gansx/fix-workflow-admission-response branch November 1, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant