Skip to content

ci: remove libsecret workaround #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pengying wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −8
Open

ci: remove libsecret workaround #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
767fcce
ci: remove mint openapi-check from lint, drop mintlify CLI from CI
pengying Apr 2, 2026
9e8efd9
fix: add trailing newline to lint.yml
pengying Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,8 @@ jobs:
node-version: '24'
cache: 'npm'

- name: Install libsecret
run: sudo apt-get update && sudo apt-get install -y libsecret-1-dev

- name: Install dependencies
run: npm ci

- name: Install mint
run: npm i -g mint
Copy link
Copy Markdown
Contributor

@jklein24 jklein24 Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm why don't we still need this?

Copy link
Copy Markdown
Contributor Author

@pengying pengying Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i guess we can leave it. I was a bit sketched out with all of the recent dependency vulnerability attacks and Mint CLI adding a keytar / libsecret dependency.

I guess the dependency is expected since Mint CLI also handles account actions.


- name: Lint
run: make lint
run: make lint
1 change: 0 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ mint:

lint:
npm run lint
cd mintlify && mint openapi-check openapi.yaml

lint-openapi:
npm run lint:openapi
Expand Down
Loading