ci: pin mintlify@4.2.284, remove libsecret workaround#316
Open
ci: pin mintlify@4.2.284, remove libsecret workaround#316
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThis PR removes the Key changes:
Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| .github/workflows/lint.yml | Removes the libsecret apt workaround and the global npm i -g mint install step; make lint now runs only via the locally-installed npm packages from npm ci. |
| Makefile | Drops mint openapi-check openapi.yaml from the lint target, meaning Mintlify-specific OpenAPI validation is no longer run in CI. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph BEFORE["Before (old CI)"]
A1[Checkout code] --> B1[Setup Node 24]
B1 --> C1["apt-get install libsecret-1-dev"]
C1 --> D1[npm ci]
D1 --> E1["npm i -g mint (latest, unpinned)"]
E1 --> F1["make lint"]
F1 --> G1["npm run lint:openapi (Redocly)"]
F1 --> H1["mint openapi-check openapi.yaml"]
end
subgraph AFTER["After (new CI)"]
A2[Checkout code] --> B2[Setup Node 24]
B2 --> C2[npm ci]
C2 --> D2["make lint"]
D2 --> E2["npm run lint:openapi (Redocly only)"]
end
style C1 fill:#f99,stroke:#c00
style E1 fill:#f99,stroke:#c00
style H1 fill:#f99,stroke:#c00
style E2 fill:#9f9,stroke:#090
Prompt To Fix All With AI
This is a comment left during a code review.
Path: Makefile
Line: 22-23
Comment:
**`mint openapi-check` validation silently dropped**
The `lint` target previously ran both `npm run lint` (Redocly) **and** `mint openapi-check openapi.yaml` for Mintlify-specific OpenAPI compatibility validation. By removing the latter, the CI no longer validates that `openapi.yaml` satisfies Mintlify's constraints — only Redocly's.
These two checkers have different rule sets; Redocly passing does not imply Mintlify compatibility. Any Mintlify-incompatible changes to the OpenAPI spec will now go undetected until they surface in a deployment or local `mint dev` run.
If skipping the check is intentional (e.g., because `mint openapi-check` is unreliable in CI), a comment to that effect, or adding the check back as a separate non-blocking job, would help future readers understand the intent.
How can I resolve this? If you propose a fix, please make it concise.Reviews (3): Last reviewed commit: "fix: add trailing newline to lint.yml" | Re-trigger Greptile
Redocly already validates the OpenAPI spec. The mint openapi-check added a transitive dependency on keytar/libsecret that breaks on bare Linux CI runners. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1024863 to
767fcce
Compare
Address PR review feedback: - Add trailing newline to .github/workflows/lint.yml The Makefile install target keeps unpinned mint since it's only for local dev, not CI. mint openapi-check is already removed from the lint target. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2173a19 to
9e8efd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Newer unpinned mint versions added openid-client which transitively
requires keytar and libsecret on Linux. Pin to the same version used
locally to avoid the issue entirely.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com