Major refactoring to make slsm simpler and easier to work with#9
Merged
Conversation
62a863b to
94eccc3
Compare
mcpherrinm
reviewed
Jul 25, 2025
|
|
||
| ctx := context.Background() | ||
|
|
||
| cfg, err := awsconfig.LoadDefaultConfig(ctx, awsconfig.WithSharedConfigProfile(os.Getenv("AWS_PROFILE"))) |
Contributor
There was a problem hiding this comment.
By default, the SDK checks the AWS_PROFILE environment variable to determine which profile to use
I know you're not touching this line, but I'm pretty sure this WithSharedConfigProfile line isn't needed
mcpherrinm
approved these changes
Jul 25, 2025
Contributor
Author
|
Merging to unblock the feature work; we can always come back and improve things more in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This major refactoring -- nearly a rewrite -- of sunlight-secretmanager removes unnecessary layers of complexity, streamlines tests, and makes the project easier to understand and evolve moving forward. It also updates sunlight-secretmanager to target v0.5.0 of Sunlight, which has made several changes to the config format since this project was started.
Specifically:
This change will be followed by a feature change which adds the ability for sunlight-secretmanager to generate new seeds when it finds a configured log that does not yet have a seed stored in AWS.