Add creating and saving new secrets#10
Merged
Merged
Conversation
aarongable
force-pushed
the
refactor
branch
5 times, most recently
from
94eccc3 to
078bb20
Compare
aarongable
force-pushed
the
seedgen
branch
2 times, most recently
from
968ddce to
c71db8d
Compare
mcpherrinm
reviewed
Jul 25, 2025
mcpherrinm
previously approved these changes
Jul 28, 2025
aarongable
dismissed
mcpherrinm’s stale review
The merge-base changed after approval.
mcpherrinm
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the secret retrieved from AWS is empty, and today is the log's "inception date" (a Sunlight-specific concept), go ahead and create and save a new seed for this log. Don't create a new seed if the inception date is in the past: theoretically, one should have already been made, so the fact that it's missing is more indicative of an error of some sort, and we don't want one log to run with two different seeds (i.e. two different signing keys). Don't create a new seed if the inception date is in the future: Sunlight itself will error out in this case, so we should never be committing configs with inception dates in the future anyway.
Warning
Do not merge before #9