Move locales to system#6
Draft
dylanmccall wants to merge 1 commit into
Draft
Conversation
dylanmccall
force-pushed
the
move-locales-to-system
branch
2 times, most recently
from
June 9, 2020 19:01
09d3d76 to
d4f9542
Compare
This change reduces the installed size of org.learningequality.Kolibri by only installing the required locales for Python modules which bundle their own locale files.
dylanmccall
force-pushed
the
move-locales-to-system
branch
from
June 19, 2020 18:37
d4f9542 to
f103b76
Compare
dylanmccall
pushed a commit
to dylanmccall/org.learningequality.Kolibri
that referenced
this pull request
Oct 5, 2021
We never want Windows binaries for any Python version. See learningequality#6
dylanmccall
pushed a commit
to dylanmccall/org.learningequality.Kolibri
that referenced
this pull request
Oct 5, 2021
This app is not built for 32-bit ARM, and never will be because no modern Flatpak runtimes support 32-bit ARM. See learningequality#6
dylanmccall
pushed a commit
to dylanmccall/org.learningequality.Kolibri
that referenced
this pull request
Oct 5, 2021
At runtime we don't need its development headers, and we don't need its manpages either. See learningequality#6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves bundled Python locales to
/app/share/locale. Normally, these are stored in separate Python module directories like/app/lib/python3.7/site-packages/..., meaning that every locale is always installed regardless of the user's preferences. With this change, all the bundled locales are split into the org.learningequality.Kolibri.Locale package, reducing the installed size in most cases.Unfortunately, it might cause problems in Kolibri depending on how it detects which languages are available for the user.
flathub#6