Remove unnecessary files in kolibri/dist#5
Merged
Conversation
This change removes unused compiled c extensions in kolibri/dist/cext, as well as standalone test suites over 100 KB.
Collaborator
Author
|
I created a separate PR, #6, in which I move bundled Python locales to |
dylanmccall
force-pushed
the
cleanup-unnecessary-kolibri-files
branch
from
June 9, 2020 18:59
37abf52 to
6912538
Compare
dylanmccall
pushed a commit
that referenced
this pull request
Jun 30, 2020
Update kolibri-installer-gnome
manuq
reviewed
Jul 7, 2020
Comment on lines
+113
to
+124
| /app/lib/python3.7/site-packages/kolibri/dist/django/contrib/flatpages/locale | ||
| /app/lib/python3.7/site-packages/kolibri/dist/django/contrib/admindocs/locale | ||
| /app/lib/python3.7/site-packages/kolibri/dist/django/contrib/sites/locale | ||
| /app/lib/python3.7/site-packages/kolibri/dist/django/contrib/sessions/locale | ||
| /app/lib/python3.7/site-packages/kolibri/dist/django/contrib/gis/locale | ||
| /app/lib/python3.7/site-packages/kolibri/dist/django/contrib/auth/locale | ||
| /app/lib/python3.7/site-packages/kolibri/dist/django/contrib/contenttypes/locale | ||
| /app/lib/python3.7/site-packages/kolibri/dist/django/contrib/postgres/locale | ||
| /app/lib/python3.7/site-packages/kolibri/dist/django/contrib/redirects/locale | ||
| /app/lib/python3.7/site-packages/kolibri/dist/django/contrib/humanize/locale | ||
| /app/lib/python3.7/site-packages/kolibri/dist/django/contrib/admin/locale | ||
| /app/lib/python3.7/site-packages/kolibri/dist/django/conf/locale |
There was a problem hiding this comment.
Maybe you can use wildcards here to reduce the maintenance of this list? Something like:
/app/lib/python3.7/site-packages/kolibri/dist/django/contrib/*/locale
Or even pass the recursive pattern "**" and use glob.glob(pathname, recursive=True) in the cleanup script?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes unused compiled c extensions in kolibri/dist/cext,
as well as standalone test suites over 100 KB.
flathub#6