Skip to content

fix(dev): kill process tree on Windows #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tatang26 merged 1 commit into from
May 8, 2026
Merged

fix(dev): kill process tree on Windows #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions dev/internal/rebuilder/sysproc_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,30 @@ package rebuilder

import (
"context"
"fmt"
"os"
"os/exec"
"os/signal"
"syscall"
)

func setSysProcAttr(cmd *exec.Cmd) {}
func setSysProcAttr(cmd *exec.Cmd) {
cmd.SysProcAttr = &syscall.SysProcAttr{
CreationFlags: syscall.CREATE_NEW_PROCESS_GROUP,
}
}

func terminateProcess(cmd *exec.Cmd) error {
return cmd.Process.Kill()
if cmd.Process == nil {
return nil
}

kill := exec.Command("taskkill", "/T", "/F", "/PID", fmt.Sprint(cmd.Process.Pid))
if err := kill.Run(); err != nil {
return cmd.Process.Kill()
}

return nil
}

func notifyContext(ctx context.Context) (context.Context, context.CancelFunc) {
Expand Down
Loading