fix(dev): kill process tree on Windows - #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
go tool devcommand on Windows, which returnedTerminateProcess: Access is deniedwhen Ctrl+C was pressed.go runexecutes the compiled binary as a child process, so when that process'sPIDis terminated, only thego runprocess is terminated, leaving the actual application running and the port blocked. Unix already addressed this with process groups (Setpgid); Windows doesn't have an equivalent.Fix:
CREATE_NEW_PROCESS_GROUPon the child process.taskkill /T /F /PIDto terminate the entire process tree.