Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/benchmarks/duckdb2-review-2026-10-01.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ This report addresses the nine comments in [review 5383705777](https://github.co
| Retained trace-index rewrite | One candidate row per trace, incrementally upserted from new contributions; no global DELETE/reinsert on normal append. Temporary trace parts contain only the current pass. |
| Compaction markers disable the index | Transfer complete cached contributions before the namespace swap. Follow replacement lineage across multiple compaction levels. Retention and incomplete replacements repair only affected trace IDs. |
| Cache footprint | Remove full span-event and log-timestamp copies and the four scope-expanded trace indexes. Keep minute counts, scoped per-batch trace parts, and one candidate per trace. |
| Stale severity semantics | A schema/aggregation version atomically discards all private read tables on mismatch and rebuilds from format-3 Parquet. Matching versions preserve acknowledgements. The already-existing endpoint_rollup/watermark cleanup now has regression coverage. |
| Stale severity semantics | A schema/aggregation version atomically discards all private read tables on mismatch and rebuilds from format-3 Parquet. Matching versions preserve acknowledgements. |
| Broad file lists | Use a glob at 64+ selected files when at least 80% of active signal files overlap; retain a captured-ID filename filter. Narrow selections retain explicit lists. Only relations actually referenced are bound. |
| Ingestion throughput interpretation | Keep #277 open. The 20→10ms admission change helps closed-loop acknowledgement latency; it does not remove CPU cost per row. |
| Warm read comparison | Explicitly label cache-current reads and add the five-minute mixed run with pending-batch samples. |
Expand Down
8 changes: 0 additions & 8 deletions internal/agent/tools_integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,6 @@ func (registryIntelligence) LatestSnapshot() *intelligence.IntelligenceSnapshot
return &intelligence.IntelligenceSnapshot{Summary: "healthy", HealthScore: 100}
}

func (registryQueries) Overview(context.Context, observability.Scope, int) (observability.Result[observability.Overview], error) {
return observability.Result[observability.Overview]{}, nil
}

func (registryQueries) Topology(context.Context, observability.Scope, int) (observability.Result[observability.Topology], error) {
return observability.Result[observability.Topology]{}, nil
}

func (registryQueries) Dependencies(context.Context, observability.Scope, observability.DependencyOptions) (observability.Result[observability.Dependencies], error) {
return observability.Result[observability.Dependencies]{}, nil
}
Expand Down
68 changes: 27 additions & 41 deletions internal/dashboard/resource_inventory_test.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package dashboard

import (
"bytes"
"encoding/json"
"os"
"path/filepath"
Expand All @@ -18,22 +19,26 @@ import (
telemetrystore "github.com/labstack/fanout/internal/telemetry/store"
)

func baselineResourcePanel(t *testing.T, p panel.Panel) panel.Panel {
func assertResourceFrame(t *testing.T, name string, frame *panel.Frame) {
t.Helper()
name := "check-states-resource-baseline.sql"
if p.ID == "versions" {
name = "versions-resource-baseline.sql"
got, err := json.MarshalIndent(frame, "", " ")
if err != nil {
t.Fatal(err)
}
sql, err := os.ReadFile(filepath.Join("testdata", name))
got = append(got, '\n')
path := filepath.Join("testdata", "resource-"+name+".golden.json")
if os.Getenv("UPDATE_RESOURCE_GOLDENS") == "1" {
if err := os.WriteFile(path, got, 0644); err != nil {
t.Fatal(err)
}
}
want, err := os.ReadFile(path)
if err != nil {
t.Fatal(err)
}
if p.ID == "versions" {
p.SQL = strings.Replace(p.SQL, versionObservationsSQL, strings.TrimSpace(string(sql)), 1)
} else {
p.SQL = strings.TrimSpace(string(sql))
if !bytes.Equal(got, want) {
t.Fatalf("%s frame differs from golden:\n%s", name, got)
}
return p
}

func resourcePanels() []panel.Panel {
Expand All @@ -48,7 +53,7 @@ func resourcePanels() []panel.Panel {

func executeResourcePanel(t *testing.T, e *panel.Executor, p panel.Panel, start, end time.Time) panel.Result {
t.Helper()
results, err := e.Run(t.Context(), panel.RunRequest{Dashboard: panel.Dashboard{Name: "Resource inventory comparison", Time: panel.Time{From: &start, To: &end}, Panels: []panel.Panel{p}}})
results, err := e.Run(t.Context(), panel.RunRequest{Dashboard: panel.Dashboard{Name: "Resource inventory", Time: panel.Time{From: &start, To: &end}, Panels: []panel.Panel{p}}})
if err != nil {
t.Fatal(err)
}
Expand All @@ -58,7 +63,7 @@ func executeResourcePanel(t *testing.T, e *panel.Executor, p panel.Panel, start,
return results[0]
}

func TestDefaultResourcePanelsMatchRawAcrossCacheStates(t *testing.T) {
func TestDefaultResourcePanelsAcrossCacheStates(t *testing.T) {
cfg := config.Config{DataDir: t.TempDir(), DuckDBMemory: "256MB", DuckDBThreads: 2, DuckDBMaxConns: 2}
repo, err := telemetrystore.Open(cfg.TelemetryDir())
if err != nil {
Expand Down Expand Up @@ -111,19 +116,13 @@ func TestDefaultResourcePanelsMatchRawAcrossCacheStates(t *testing.T) {
}
}
for _, p := range resourcePanels() {
want := executeResourcePanel(t, e, baselineResourcePanel(t, p), start, end)
got := executeResourcePanel(t, e, p, start, end)
if !reflect.DeepEqual(want.Frame, got.Frame) {
t.Fatalf("%s frames differ: raw=%+v inventory=%+v", p.ID, want.Frame, got.Frame)
}
assertResourceFrame(t, p.ID, got.Frame)
// A shifted SQL execution carries its own logical inventory window.
shifted := p
shifted.Time = &panel.PanelTime{Shift: "1m"}
want = executeResourcePanel(t, e, baselineResourcePanel(t, shifted), start, end)
got = executeResourcePanel(t, e, shifted, start, end)
if !reflect.DeepEqual(want.Frame, got.Frame) {
t.Fatalf("shifted %s frames differ: raw=%+v inventory=%+v", p.ID, want.Frame, got.Frame)
}
assertResourceFrame(t, p.ID+"-shifted", got.Frame)
}
})
}
Expand Down Expand Up @@ -157,11 +156,8 @@ func TestDefaultResourceInventoryKeepsVantageNamespacesSeparate(t *testing.T) {
if p.ID != "check_states" {
continue
}
want := executeResourcePanel(t, e, baselineResourcePanel(t, p), start, end)
got := executeResourcePanel(t, e, p, start, end)
if !reflect.DeepEqual(want.Frame, got.Frame) {
t.Fatal("namespace vantage frames differ")
}
assertResourceFrame(t, "namespaces", got.Frame)
for _, value := range defaultValues(t, got, "endpoint_from") {
if strings.Contains(value.(string), "all checks run on service hosts") {
t.Fatal("another namespace made a check local")
Expand Down Expand Up @@ -219,8 +215,7 @@ func TestResourceInventoryFrozenSnapshotFrames(t *testing.T) {
stats := map[string]any{"engine": engine, "start": start, "end": end}
sqlEvidence := map[string]string{}
for _, p := range resourcePanels() {
sqlEvidence[p.ID+"-before"] = baselineResourcePanel(t, p).SQL
sqlEvidence[p.ID+"-after"] = p.SQL
sqlEvidence[p.ID] = p.SQL
}
write("panel-sql.json", sqlEvidence)
build := time.Now()
Expand Down Expand Up @@ -268,28 +263,19 @@ func TestResourceInventoryFrozenSnapshotFrames(t *testing.T) {
}
stats["inventory_rows_by_signal"] = bySignal
for _, p := range resourcePanels() {
var before, after []int64
var elapsed []int64
var want *panel.Frame
for i := range 4 {
r := executeResourcePanel(t, e, baselineResourcePanel(t, p), start, end)
before = append(before, r.ElapsedMS)
r := executeResourcePanel(t, e, p, start, end)
elapsed = append(elapsed, r.ElapsedMS)
if i == 0 {
want = r.Frame
} else if !reflect.DeepEqual(want, r.Frame) {
t.Fatal("unstable baseline frame")
}
}
write(p.ID+"-before.json", want)
for range 4 {
r := executeResourcePanel(t, e, p, start, end)
after = append(after, r.ElapsedMS)
if !reflect.DeepEqual(want, r.Frame) {
t.Fatalf("frozen %s rows, ordering or frame metadata differ", p.ID)
t.Fatalf("unstable frozen %s frame", p.ID)
}
write(p.ID+"-after.json", r.Frame)
}
stats[p.ID+"_before_ms"] = before
stats[p.ID+"_after_ms"] = after
write(p.ID+".json", want)
stats[p.ID+"_ms"] = elapsed
stats[p.ID+"_rows"] = want.Rows
}
stats["cache_wal_bytes_before_checkpoint"] = int64(0)
Expand Down
27 changes: 0 additions & 27 deletions internal/dashboard/testdata/check-states-resource-baseline.sql

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
{
"columns": [
{
"name": "time",
"type": "time",
"role": "time"
},
{
"name": "endpoint_from",
"type": "string",
"role": "dimension"
},
{
"name": "failure",
"type": "number",
"role": "measure"
},
{
"name": "state",
"type": "string",
"role": "dimension"
}
],
"values": [
[
1790855940000,
1790855940000,
1790856000000,
1790856000000
],
[
"prod / GET https://example.test from lookback-only (all checks run on service hosts; outside reachability unverified)",
"prod / GET https://example.test from same-host (all checks run on service hosts; outside reachability unverified)",
"prod / GET https://example.test from lookback-only (all checks run on service hosts; outside reachability unverified)",
"prod / GET https://example.test from same-host (all checks run on service hosts; outside reachability unverified)"
],
[
2,
2,
2,
2
],
[
"no recent result",
"reporting interval unknown",
"no recent result",
"no recent result"
]
],
"rows": 4
}
43 changes: 43 additions & 0 deletions internal/dashboard/testdata/resource-check_states.golden.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
{
"columns": [
{
"name": "time",
"type": "time",
"role": "time"
},
{
"name": "endpoint_from",
"type": "string",
"role": "dimension"
},
{
"name": "failure",
"type": "number",
"role": "measure"
},
{
"name": "state",
"type": "string",
"role": "dimension"
}
],
"values": [
[
1790856000000,
1790856060000
],
[
"prod / GET https://example.test from same-host (all checks run on service hosts; outside reachability unverified)",
"prod / GET https://example.test from same-host (all checks run on service hosts; outside reachability unverified)"
],
[
2,
2
],
[
"no recent result",
"no recent result"
]
],
"rows": 2
}
39 changes: 39 additions & 0 deletions internal/dashboard/testdata/resource-namespaces.golden.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
{
"columns": [
{
"name": "time",
"type": "time",
"role": "time"
},
{
"name": "endpoint_from",
"type": "string",
"role": "dimension"
},
{
"name": "failure",
"type": "number",
"role": "measure"
},
{
"name": "state",
"type": "string",
"role": "dimension"
}
],
"values": [
[
1790856000000
],
[
"prod / GET https://example.test from same-host"
],
[
0
],
[
"reachable"
]
],
"rows": 1
}
Loading
Loading