Skip to content

refactor: remove legacy and fallback code paths - #345

Merged
vishr merged 1 commit into
mainfrom
refactor/remove-legacy
Oct 18, 2026
Merged

vishr merged 1 commit into
mainfrom
refactor/remove-legacy

Conversation

@vishr

@vishr vishr commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

Summary

No code path supports retired data, formats, responses or producers any more:

  • Overview and topology no longer build the old response envelopes.
  • Log patterns group by body_template directly; batch format 4 always has it.
  • Panel interaction reads the explicit interactive flag only, not a · previous series-name suffix.
  • Startup no longer cleans up the retired endpoint_rollup table; cache version changes already rebuild private read tables.
  • Span status predicates accept only STATUS_CODE_ERROR, the value ingest stores; log severity ERROR is unchanged.
  • The dashboard evaluator accepts only current event shapes.
  • Tests compare against expected outputs instead of retired SQL (three historical SQL files deleted).

OpenTelemetry semantic-convention extraction prefers the current attribute names (http.request.method, http.response.status_code, db.system.name, deployment.environment.name) and reads older names only when a producer still sends them; external SDKs still emit them.

Published migrations and cache rebuilds stay, as AGENTS.md requires.

Verification

  • go vet ./..., go test ./..., race tests on touched packages; UI lint and 1,408 UI tests; just ui-check; just docs-generate-check; evaluator tests (123).
  • Codex adversarial review: no material findings.
  • just check in the pre-push hook.

No code path supports retired data, formats, responses or producers any
more:

- Overview and topology no longer build the old response envelopes.
- Log patterns group by body_template directly; batch format 4 always has
  it.
- Panel interaction reads the explicit interactive flag only, not a
  " · previous" series-name suffix.
- Startup no longer cleans up the retired endpoint_rollup table; cache
  version changes already rebuild private read tables.
- Span status predicates accept only STATUS_CODE_ERROR, the value ingest
  stores; log severity ERROR is unchanged.
- The dashboard evaluator accepts only current event shapes.
- Tests compare against expected outputs instead of retired SQL.

OpenTelemetry semantic-convention extraction now prefers the current
attribute names (http.request.method, http.response.status_code,
db.system.name, deployment.environment.name) and reads the older names
only when a producer still sends them.

Claude-Session: https://claude.ai/code/session_018HfyEXHyGD1utmKF4CQtyQ
@vishr
vishr merged commit e418156 into main Oct 18, 2026
16 checks passed
@vishr
vishr deleted the refactor/remove-legacy branch October 18, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant