Repository navigation
refactor: remove legacy and fallback code paths - #345
Merged
Merged
Conversation
No code path supports retired data, formats, responses or producers any more: - Overview and topology no longer build the old response envelopes. - Log patterns group by body_template directly; batch format 4 always has it. - Panel interaction reads the explicit interactive flag only, not a " · previous" series-name suffix. - Startup no longer cleans up the retired endpoint_rollup table; cache version changes already rebuild private read tables. - Span status predicates accept only STATUS_CODE_ERROR, the value ingest stores; log severity ERROR is unchanged. - The dashboard evaluator accepts only current event shapes. - Tests compare against expected outputs instead of retired SQL. OpenTelemetry semantic-convention extraction now prefers the current attribute names (http.request.method, http.response.status_code, db.system.name, deployment.environment.name) and reads the older names only when a producer still sends them. Claude-Session: https://claude.ai/code/session_018HfyEXHyGD1utmKF4CQtyQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No code path supports retired data, formats, responses or producers any more:
body_templatedirectly; batch format 4 always has it.interactiveflag only, not a· previousseries-name suffix.endpoint_rolluptable; cache version changes already rebuild private read tables.STATUS_CODE_ERROR, the value ingest stores; log severityERRORis unchanged.OpenTelemetry semantic-convention extraction prefers the current attribute names (
http.request.method,http.response.status_code,db.system.name,deployment.environment.name) and reads older names only when a producer still sends them; external SDKs still emit them.Published migrations and cache rebuilds stay, as AGENTS.md requires.
Verification
go vet ./...,go test ./..., race tests on touched packages; UI lint and 1,408 UI tests;just ui-check;just docs-generate-check; evaluator tests (123).just checkin the pre-push hook.