Skip to content

Migrate Kubernetes asyncio generation to OpenAPI Generator v7 - #306

Merged
kubernetes-prow[bot] merged 4 commits into
kubernetes-client:masterfrom
tamird:prototype/python-modern-generator-async
Jul 28, 2026
Merged

Migrate Kubernetes asyncio generation to OpenAPI Generator v7#306
kubernetes-prow[bot] merged 4 commits into
kubernetes-client:masterfrom
tamird:prototype/python-modern-generator-async

Conversation

@tamird

@tamird tamird commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Generate kubernetes.aio with the OpenAPI Generator v7 asyncio backend and dependency-free Python templates from OpenAPITools/openapi-generator#24402.

Build on the merged synchronous generator in #305. Use a dedicated python-aio configuration and generator-owned postprocessing for Kubernetes authentication, TLS, watches, WebSockets, and PATCH requests; keep the independent python-asyncio generator and synchronous delete behavior unchanged. The corresponding generated client is kubernetes-client/python#2647.

The recorded generator version is 7.25.0-SNAPSHOT; v7.24.0 remains the latest published release: https://github.com/OpenAPITools/openapi-generator/releases/tag/v7.24.0.

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 23, 2026
tamird added a commit to tamird/gen that referenced this pull request Jul 23, 2026
@tamird
Split asynchronous generator migration into its own pull request
fc5b727 
Limit this change to synchronous Kubernetes Python generation and shared Python processing. Move the asynchronous entrypoint and configuration to kubernetes-client#306 so the synchronous migration can be reviewed and merged first.
@tamird tamird mentioned this pull request Jul 23, 2026
Merged
tamird added a commit to tamird/gen that referenced this pull request Jul 23, 2026
@tamird
Split asynchronous generator into its own pull request
7f74c6d 
Limit this change to synchronous Kubernetes Python generation and shared Python processing. The asynchronous entrypoint and configuration are proposed separately in kubernetes-client#306 so the synchronous migration can land first.
@tamird

tamird commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

/assign @yliaog

@kubernetes-prow kubernetes-prow Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 23, 2026
@tamird tamird mentioned this pull request Jul 23, 2026
Merged
@kubernetes-prow kubernetes-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 27, 2026
@tamird tamird changed the title Migrate asynchronous Python client generation to v7.24.0 Migrate Kubernetes asyncio generation to OpenAPI Generator v7 Jul 27, 2026
@tamird tamird mentioned this pull request Jul 27, 2026
Merged
@tamird
tamird force-pushed the prototype/python-modern-generator-async branch from f7bd547 to 394af0c Compare July 28, 2026 01:34
@kubernetes-prow kubernetes-prow Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 28, 2026
@yliaog

yliaog commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

please resolve the conflicts

@kubernetes-prow kubernetes-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 28, 2026
@tamird
tamird force-pushed the prototype/python-modern-generator-async branch from 394af0c to 1703406 Compare July 28, 2026 05:57
@kubernetes-prow kubernetes-prow Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 28, 2026
@tamird

tamird commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

@yliaog Rebased onto fa1b9c8, so the synchronous generator is inherited from master and this PR is conflict-free. The asyncio result at 1703406 is byte-for-byte unchanged.

GitHub is waiting for maintainer approval to run the new-head checks: https://github.com/kubernetes-client/gen/actions/runs/30333192839.

[tamirdex]

yliaog
yliaog reviewed Jul 28, 2026
View reviewed changes
Comment thread openapi/test_preprocess.py
Comment thread openapi/preprocess_spec.py Outdated
Comment thread openapi/postprocess_python.py
yliaog
yliaog reviewed Jul 28, 2026
View reviewed changes
Comment thread openapi/preprocess_spec.py Outdated
Comment thread openapi/postprocess_python.py
Comment thread openapi/postprocess_python.py
Comment thread openapi/postprocess_python.py
Comment thread openapi/postprocess_python.py
@tamird

tamird commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

@yliaog Addressed all six review threads in bfcad56. Each asyncio compatibility block now names its original v6 patch; the synchronous client keeps its exact namespace-only behavior, and broader deletion handling is limited to python-aio. The independent python-asyncio generator remains unchanged.

GitHub is awaiting maintainer approval for the new-head run: https://github.com/kubernetes-client/gen/actions/runs/30402681792.

[tamirdex]

@yliaog

yliaog commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

thanks for the PR

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2026
@kubernetes-prow

kubernetes-prow Bot commented Jul 28, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tamird, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit d8bc4d0 into kubernetes-client:master Jul 28, 2026
3 checks passed
@tamird
tamird deleted the prototype/python-modern-generator-async branch July 28, 2026 22:32
This was referenced Jul 28, 2026
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yliaog yliaog yliaog left review comments
@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@yliaog yliaog

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tamird @yliaog