Skip to content

Align Python resource deletion responses - #309

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-client:masterfrom
tamird:tamird/sync-job-delete-status-compat
Jul 31, 2026
Merged

Align Python resource deletion responses#309
kubernetes-prow[bot] merged 1 commit into
kubernetes-client:masterfrom
tamird:tamird/sync-job-delete-status-compat

Conversation

@tamird

@tamird tamird commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Kubernetes can return either a deleted resource or a Status from an individual deletion, but its Swagger 2 response schema names only Status. Apply the existing guarded schema correction to both Python generators so synchronous and asyncio clients preserve the complete response as a dictionary. Collection deletions and already resource-typed responses remain unchanged.

This intentionally changes 58 synchronous individual-deletion methods and their HTTP-info variants from V1Status to dictionaries relative to released v36. Callers using result.status should migrate to result.get("status").

Downstream: kubernetes-client/python#2664
Maintainer discussion: #306 (comment)

@kubernetes-prow
kubernetes-prow Bot requested review from yliaog and yue9944882 July 30, 2026 21:53
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 30, 2026
@tamird
tamird force-pushed the tamird/sync-job-delete-status-compat branch from e3d5f68 to 9a487d3 Compare July 30, 2026 23:37
@kubernetes-prow kubernetes-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 30, 2026
@tamird tamird changed the title Preserve synchronous Job deletion compatibility Align Python resource deletion responses Jul 30, 2026
@yliaog

yliaog commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2026
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tamird, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit 5cd69a3 into kubernetes-client:master Jul 31, 2026
3 checks passed
@tamird
tamird deleted the tamird/sync-job-delete-status-compat branch July 31, 2026 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants