Repository navigation
fix(sync): a page's time budget counts applying, not its rewind (T13275) - #1924
Merged
Merged
Conversation
#1923 review LOW: pageMs was measured from before rewindTxns, so a large scope could leave every page one txn that rewound and replayed the same scope again. The bound now starts after the rewind. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: T13275
Follow-up to #1923 (review LOW), stacked on it.
What changes
pageMswas measured frompageStart, beforerewindTxns. With a large scope, the rewind alone could use the budget. Every page then admitted one txn and rewound and replayed the same scope again, an O(txns × scope) churn under the write lock. The page clock (applyStart) now starts after the rewind.Tests
pageMs: 50, three foreign txns still share one page (applied_frame) and are all rebased.pageStartagain fails the test.Locally green:
--base origin/feat/T13193-pages).🤖 Generated with Claude Code