Repository navigation
feat(sync): held rows in cloud status, doctor sync-journal and pull results (T13271) - #1925
Merged
Merged
Conversation
…esults (T13271) Journal spec §3.5 Rule 5 surfaces (the data API shipped with R-3): - CloudStatusSyncStream.held (contracts): count, oldest, long holds (older than HELD_WARN_DAYS = 7) with their conflict preview; the human clause names them. - cleo doctor sync-journal: SyncRepairResult.holds (holdsReport). - ApplyReport.held: local txns a pull left held (a later page of the same call that applied one drops it). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…lyReport, CLI (T13271) The implementation b3b3e12's message describes; only its changeset and test were committed (a git stash pop around a gate check left the source unstaged, and the next PR's commit picked it up). One task per PR: this moves it back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kryptobaseddev
added a commit
that referenced
this pull request
Oct 6, 2026
# Conflicts: # packages/cleo/src/cli/lib/nexus-cloud-cli.ts # packages/contracts/src/nexus-cloud.ts # packages/core/src/cloud/nexus-cloud-status.ts # packages/core/src/doctor/sync-repair.ts # packages/core/src/store/sync/apply/applier.ts
…aces # Conflicts: # packages/core/src/cloud/nexus-cloud-status.ts
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: T13271
The remaining journal spec §3.5 Rule 5 surfaces for held rows. Stacked on #1924. The data API (
listHeldOps) shipped with R-3 (#1920).What changes
cleo cloud status.CloudStatusHeld/CloudStatusHeldRow, andCloudStatusSyncStream.held, which carries the count, the oldest hold, and the long holds with their conflict preview.readStoreSyncStreamfills it fromholdsReport, read-only on the snapshot.syncStreamClauseso it can be tested.cleo doctor sync-journal.SyncRepairResult.holdsis aHoldsReport(total, oldest, long holds pastHELD_WARN_DAYS= 7), in both the dry run and--repair.ApplyReport.heldlists the local txns the call left held.replayTxnsreturns what it held, and the list drops any txn a later page of the same call applied.Tests
held: [lk];held.count = 1;total = 1withlong: []now, and lists the hold, with its dangling-ref reason, once the clock is past 7 days;held: []and the status count is 0.pageOps: 1holds an insert on B's page and applies it on C's page, and reportsheld: [].Locally green:
--check), 10, 19, 25, 28, 38 (--base origin/fix/T13275-page-clock) and 40;🤖 Generated with Claude Code