feature: add hotel management system#263
Conversation
|
@Chirantan112 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Chirantan112 ensure that all checks pass before merging |
komalharshita
left a comment
There was a problem hiding this comment.
Good contribution overall. The Hotel Management System project is a useful addition to DevPath and fits well within the repository’s educational/project-learning goals.
The project structure, roadmap, features, and starter code organization are all well scoped for beginners/intermediate learners practicing data management and application logic concepts.
The PR is clean, properly linked to the issue, and avoids unrelated modifications.
Minor future suggestion: slightly clarify the intended implementation type (CLI/web/GUI) in the description and ensure the starter template remains beginner-friendly rather than overly complete.
Approved for merge.
|
Hi @komalharshita, thank you for the approval! I noticed that the CI checks were failing due to a universal bug in tests/test_basic.py (the test_health_check is missing a required argument). I have raised Issue #344 to document this and submitted PR #345 to fix it. Once the test fix is merged, the checks for this project will pass. I've also updated the project description to clarify that this is a CLI-based implementation as suggested! |
Updated the project header in hotel_management.py to explicitly state that this is a CLI (Command Line Interface) implementation. This addresses the maintainer's feedback regarding clarity for beginner/intermediate learners.
|
Hi @komalharshita, I've updated the file header and description to clarify this is a CLI implementation as suggested. Thank you for the approval!" |
Replaced all occurrences of the ₹ symbol with 'Rs.' throughout hotel_management.py. This change ensures the code is compatible with standard ASCII/UTF-8 encoding used by GitHub Actions and various terminal environments, preventing potential build failures or display errors during automated testing.
Summary
This PR implements the Python-based Hotel Management System Starter as proposed in issue #204. It provides a structured, medium-difficulty learning project for the
starter_codelibrary, focusing on real-world logic like room inventory management and guest data validation.Related Issue
Closes #204
Type of Change
What Was Changed
starter_code/hotel_management.pyKey Features Implemented
How to Test This PR
cd starter_codepython hotel_management.pySelf-Review Checklist
flake8 .locally and fixed any linting errors.print()debug statements.Notes for Reviewer
This PR successfully fulfills the requirements outlined in the project proposal (#204). The code is modular and follows the educational style of the existing
grade_manager.pyto ensure consistency for new contributors.