fix(ci): dedupe capture-aws-control server, unbreak jscpd gate on main

[CrysisDeu]

Problem / Motivation

The Copy/paste detection step (npx jscpd ., threshold 0%) in Frontend Lint & Type Check fails on every branch cut from current main: ERROR: jscpd found too many duplicates (0.01%) over threshold (0%). Reproduced on a pristine origin/main worktree with the pinned jscpd — this is main's own breakage, not any PR's.

Why it matters

Every open PR red-lights on a gate its diff cannot influence; contributors burn CI rounds triaging a failure that is inherited. (Hit live while babysitting #6428.)

What changed (motivation → approach → change)

capture-aws-control.mjs (landed recently) hand-rolled the same 17-line static-file server that capture-hero-art-proxy.mjs carries, pushing repo-wide duplication from one tolerated clone (rounds to 0%) to two (0.01% > 0%). The repo already has the shared harness helper for exactly this: scripts/lib/serve-dist.mjs. The fix deletes the hand-rolled server from capture-aws-control.mjs and uses serveDist() (ephemeral port instead of hardcoded 6813, same SPA-fallback + /logo.png behavior — the helper is the canonical implementation the other harnesses use).

Tests

jscpd on this branch: back to 1 clone / exit 0 (the pre-existing queue-edit/upload-error pair, which rounds to 0% and passes). N/A for unit tests — capture harness script, not shipped code.

Manual verification

Ran the fixed script end-to-end against a built dist (node scripts/capture-aws-control.mjs /tmp/aws-verify): server starts on an ephemeral port, SPA loads, home.png and account.png captured. node --check clean.

Why no screenshot: capture-harness plumbing only; no shipped UI renders differently.

Related Issues

no linked issue: found while babysitting #6428; fixed directly as a main-unblocker.

Checklist

• At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)
• Existing tests pass and new tests added for new functionality — N/A, harness script
• Self-review completed; code follows project style guidelines
• Documentation updated (if applicable) — N/A
• No secrets, credentials, or internal references in the diff

[github-actions]

UX Review (Fable 5) — ✅ PASS

UX-level review of a2db9d2bec83a5c679e783ad6a0c4a3d136d4b5e — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Developer-only refactor of a screenshot-capture script; no user-facing UI, strings, states, or screenshots change — nothing a product user ever sees.

[UX-REVIEWED] a2db9d2

[github-actions]

Design Review (Fable 5) — ✅ PASS

Design-level review of a2db9d2bec83a5c679e783ad6a0c4a3d136d4b5e — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Root-cause dedupe onto the existing canonical helper (serveDist), not a threshold bump or jscpd ignore — the right shape, verified end-to-end.

[DESIGN-REVIEWED] a2db9d2

[github-actions]

Opus 4.8 Review — ✅ no blocking findings

Reviewed a2db9d2bec83a5c679e783ad6a0c4a3d136d4b5e — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] a2db9d2

Verdict parsed from the review's SHA-scoped output markers for commit a2db9d2bec83a5c679e783ad6a0c4a3d136d4b5e.

False positive or not applicable? A repository writer can comment:
/ai-review override fable a2db9d2bec83a5c679e783ad6a0c4a3d136d4b5e: <one-sentence reason>

[github-actions]

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of a2db9d2bec83a5c679e783ad6a0c4a3d136d4b5e and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] a2db9d2

False positive or not applicable? A repository writer can comment:
/ai-review override gpt a2db9d2bec83a5c679e783ad6a0c4a3d136d4b5e: <one-sentence reason>

[NicholasRBowers]

Tier 1 auto-approve: fix (1 file). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, SAST annotations clean, security checklist all-NO, AI reviewers green. Category: single-file CI capture-script fix with clear root cause — replaces the duplicated inline static server in capture-aws-control.mjs with the shared serveDist() helper, unbreaking the jscpd duplication gate on main.