Skip to content

fix(ci): dedupe the split-pane chat harness page wiring - #6445

Merged
NicholasRBowers merged 1 commit into
mainfrom
fix/dedupe-split-chat-page-harness
Aug 28, 2026
Merged

fix(ci): dedupe the split-pane chat harness page wiring#6445
NicholasRBowers merged 1 commit into
mainfrom
fix/dedupe-split-chat-page-harness

Conversation

@CrysisDeu

Copy link
Copy Markdown
Collaborator

Summary

Repo-wide jscpd is red on every merge ref: capture-chatpane-queue-edit.mjs and capture-chatpane-upload-error.mjs carry the same 14-line preparePage stanza (route fallback, websocket silence, split-layout seed, app open). This is the sibling of #6434, which cleared the other clone pair (aws-control / hero-art-proxy) via serveDist.

Extracts the stanza into scripts/lib/prepare-split-chat-page.mjs with a pre hook carrying the upload harness's 400 intercept.

  • npx jscpd . in website/: 0 clones (was 1 pair)
  • node --check on all three files: clean
  • Behavior-preserving: the upload harness reaches the same state before and after (verified by running both versions locally — it progresses to the 2-pane split identically; its banner-wait failure is pre-existing on main in this environment, unrelated to the dedupe)

Unblocks the Frontend Lint & Type Check job for every open frontend PR (first observed on #6419's merge ref).

capture-chatpane-queue-edit.mjs and capture-chatpane-upload-error.mjs
carried the same 14-line preparePage stanza (route fallback, websocket
silence, split-layout seed), which tips repo-wide jscpd duplication over
the 0% gate on every merge ref. Extract it into
scripts/lib/prepare-split-chat-page.mjs with a `pre` hook for the
upload harness's 400 intercept — the same shape as the serveDist dedupe.
@CrysisDeu
CrysisDeu requested a review from a team as a code owner August 28, 2026 00:53
@CrysisDeu
CrysisDeu requested a review from hoang-phan98 August 28, 2026 00:53
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Aug 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — ✅ PASS

UX-level review of 788024eeddb28dd906780e5a8168e97ab388df81 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

CI-harness refactor only — no user-facing UI, strings, or screenshots change; nothing a product user ever sees.

[UX-REVIEWED] 788024e

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of 788024eeddb28dd906780e5a8168e97ab388df81 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Textbook extraction of a verbatim clone into the same scripts/lib/ seam #6434 established, with a minimal pre hook covering the one real divergence.

[DESIGN-REVIEWED] 788024e

@github-actions

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of 788024eeddb28dd906780e5a8168e97ab388df81 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 788024e

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 788024eeddb28dd906780e5a8168e97ab388df81: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

Opus 4.8 Review — ✅ no blocking findings

Reviewed 788024eeddb28dd906780e5a8168e97ab388df81 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 788024e

Verdict parsed from the review's SHA-scoped output markers for commit 788024eeddb28dd906780e5a8168e97ab388df81.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 788024eeddb28dd906780e5a8168e97ab388df81: <one-sentence reason>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Aug 28, 2026
@NicholasRBowers
NicholasRBowers enabled auto-merge (squash) August 28, 2026 01:27

@NicholasRBowers NicholasRBowers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: chore/fix — CI capture-harness dedup (3 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, SAST annotations clean, security checklist all-NO, AI reviewers green. Category: fix, ≤5 files with clear root cause — extracts the duplicated split-pane page-wiring stanza from two offline screenshot-capture scripts into a shared prepare-split-chat-page helper, satisfying the jscpd duplication gate; no runtime surface.

@NicholasRBowers
NicholasRBowers merged commit 17ad38f into main Aug 28, 2026
65 checks passed
@NicholasRBowers
NicholasRBowers deleted the fix/dedupe-split-chat-page-harness branch August 28, 2026 01:28
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants