Skip to content

fix(i18n): reword the co-author discard confirm to informal Hindi register - #5850

Closed
iamwhatever wants to merge 1 commit into
mainfrom
fix/hi-aap-ratchet-5843
Closed

fix(i18n): reword the co-author discard confirm to informal Hindi register#5850
iamwhatever wants to merge 1 commit into
mainfrom
fix/hi-aap-ratchet-5843

Conversation

@iamwhatever

Copy link
Copy Markdown
Collaborator

Problem / Motivation

website/src/i18n/style/hiStyle.test.ts > hi tone (style/hi.md §4) > does not use formal आप fails on current main: the formal-आप usage count reached 120 against the baselined ceiling of 119. Because Frontend Tests runs on the merge ref, every open PR inherits this failure — the repo cannot land anything green until main heals.

Why it matters

All PRs are mechanically un-greenable: their Frontend Tests shard goes red on code they never touched, and (for fork PRs) the review-bot workflows that gate on CI success never re-stamp, so PR Readiness stays stuck too.

What changed (motivation → approach → change)

  • Symptom: ratchet at 120 vs 119.
  • Root cause: fix(i18n): confirm bodies lead with consequence, one discard verb (#5243) #5529 (d805995e) added the 120th formal-आप value — apps.papyrus.workspace.co_author_conflict_discard_confirm in hi.json uses आपके ("your", formal). Verified by diffing the violating-key sets before/after that commit: it is the only addition.
  • Fix: reword to the informal register the style guide mandates (style/hi.md §4: address the user as तुम, not आप): आपकेतुम्हारे. This matches the existing catalog convention (99 existing तुम्हारे usages). The baseline stays at 119 — the ratchet's purpose is to force exactly this reword, not to be bumped.

Tests

No new test: the existing ratchet (hiStyle.test.ts) is the regression guard and now passes — npx vitest run src/i18n/style/hiStyle.test.ts → 2/2 green on this branch, fails on main.

Manual verification

npm run i18n:check and npm run lint:i18n both exit 0. The value keeps the {{file}} placeholder and the purna viram punctuation intact.

Why no screenshot: single translated-string reword in the Hindi catalog; no layout, key, or component change.

Related Issues

Fixes #5843

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable) — N/A
  • No secrets, credentials, or internal references in the diff

…ister

The hiStyle formal-aap ratchet (ceiling 119) reached 120 on main: #5529
added apps.papyrus.workspace.co_author_conflict_discard_confirm to
hi.json with formal aapke. style/hi.md section 4 mandates the informal
register (tum), so reword aapke -> tumhare, matching the 99 existing
tumhare usages in the catalog. Baseline stays at 119: the ratchet
exists to force this reword, not to be bumped.

Frontend Tests runs on the merge ref, so every open PR inherited this
failure until main heals.

Fixes #5843
@github-actions

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of 0552f04f3d862c3e5a56988baa9e765fd9f2bb18 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 0552f04

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 0552f04f3d862c3e5a56988baa9e765fd9f2bb18: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

Opus 4.8 Review — ✅ no blocking findings

Reviewed 0552f04f3d862c3e5a56988baa9e765fd9f2bb18 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 0552f04

Verdict parsed from the review's SHA-scoped output markers for commit 0552f04f3d862c3e5a56988baa9e765fd9f2bb18.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 0552f04f3d862c3e5a56988baa9e765fd9f2bb18: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — ✅ PASS

Premise-level review of 0552f04f3d862c3e5a56988baa9e765fd9f2bb18 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

The patch is a one-line reword in website/src/i18n/locales/hi.json, and everything the description claims checks out against the repo: style/hi.md §4 mandates तुम over आप, hiStyle.test.ts pins the formal-आप ceiling at 119 with the false-positive stripping the description alludes to, the new value keeps {{file}} and the purna viram, and my own grep of the catalog finds 100 तुम्हारे occurrences (99 pre-existing + this one) and 44 remaining baselined आपके values covered by the ratchet's recorded ceiling. Nothing rides along.

First-Principles-Verdict: PASS

One string reworded to the register the style guide and its ratchet mandate; the reword, not a baseline bump, is exactly what the ratchet exists to force.

What this change ships

Intent: un-wedge CI for every open PR by fixing the 120th formal-आप string that tripped the Hindi register ratchet. FIX.

  1. The co-author discard confirmation now addresses the user informally (आपके → तुम्हारे) — justified (style/hi.md §4, hiStyle.test.ts ceiling 119).

No baseline edit, no key change, no rider items. The 119 remaining formal-आप values (44 of them आपके, counted in hi.json) are the ratchet's own recorded, baselined debt — deferred by the test's documented ceiling, not left by this fix.

[FIRST-PRINCIPLES-REVIEWED] 0552f04

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of 0552f04f3d862c3e5a56988baa9e765fd9f2bb18 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Correct root-cause fix: rewords the one string that tripped the ratchet instead of bumping the baseline, restoring green CI for every open PR.

[DESIGN-REVIEWED] 0552f04

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — 🟡 CONCERNS

UX-level review of 0552f04f3d862c3e5a56988baa9e765fd9f2bb18 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

The reword makes the discard dialog internally inconsistent: the body now says तुम while the title, button, and trigger label stay in formal आप-register.

Watch

  • Half-migrated register inside one destructive dialog — the body was changed to informal ("तुम्हारे सहेजे न गए बदलाव…") but its own title "सहेजे न गए बदलाव छोड़ें?", confirm button "बदलाव छोड़ें", and trigger "मेरे बदलाव छोड़ें और फिर लोड करें" keep the formal छोड़ें/करें imperatives (hi.json:3966–3969). Before this PR the dialog was uniformly formal; now a Hindi reader sees mixed address in a single irreversible-discard confirmation, which reads sloppy exactly where trust matters most. Low frequency (Hindi locale, conflict path only) × low impact (tone, not comprehension) × persistent. Fix: convert the dialog's sibling strings to the same informal register (छोड़ो / तुम forms) in this PR, or revert the body to आपके.

Suggestions

  • If informal is the Papyrus-wide direction, also sweep the adjacent workspace strings still in formal register ("दबाएँ" in save_and_compile_hint, "हटाएँ?" in delete_file_confirm) so the app doesn't flip register between toolbar and dialogs.

[UX-REVIEWED] 0552f04

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Aug 25, 2026
@iamwhatever

Copy link
Copy Markdown
Collaborator Author

Note for the reviewer: the three red Backend Tests (shard 4) lanes on this PR are the OTHER pre-existing main breakage, #5846 (test_trust_reads redirect contradiction between #5541 and #5521) — reproduced on pristine main, unrelated to this hi.json reword. That one needs a maintainer security-posture call per the issue. This PR heals the frontend half (#5843); merging it un-blocks every open PR's Frontend Tests shard.

@iamwhatever

Copy link
Copy Markdown
Collaborator Author

Closing as already fixed upstream — no longer needed.

ff15bbe14 (PR #3410, @kyleseaman, merged 16:27 UTC) carries this PR's exact change verbatim in its fix(ci): stabilize inherited gate failures commit:

-  "co_author_conflict_discard_confirm": "…में आपके सहेजे न गए बदलाव…"
+  "co_author_conflict_discard_confirm": "…में तुम्हारे सहेजे न गए बदलाव…"

It went one further and also reworded group_attention (आपकीतुम्हारी), so the hiStyle formal-आप count on main is now 118 against the ceiling of 119 — back under budget with a commit of headroom.

Verified against main's code, not inferred: rebasing this branch onto b59cc56cf makes git drop the commit itself — patch contents already upstream — leaving a zero-line diff and zero commits ahead. Re-counting violations directly on main's hi.json gives 118, and the target key already reads तुम्हारे.

Issue #5843 is therefore resolved on main and can be closed independently of this PR.

@iamwhatever
iamwhatever deleted the fix/hi-aap-ratchet-5843 branch August 25, 2026 17:21
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

main is red: hiStyle formal-aap ratchet at 120 vs 119 baseline, fails every PR's Frontend Tests

1 participant