fix: convert hardcoded plural-glue labels to i18nT count keys (#5820) - #5876
Conversation
github-actions
Bot
added
the
readiness: checking
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Correct root-cause fix: the plural decision moves inside the translate call, catalogs carry each language's own categories, and the detector ceiling ratchets down with the conversion. Suggestions
[DESIGN-REVIEWED] 94342b3 |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
UX Review (Fable 5) — ✅ PASSUX-level review of UX-Verdict: PASS Ten mixed-language count labels now render fully localized, English output stays byte-identical, and the screenshots confirm the en/zh-CN/ru renderings pixel-for-pixel. [UX-REVIEWED] 94342b3 |
First Principles Review (Fable 5) — ✅ PASSPremise-level review of This is a clean, mechanical i18n conversion. All inventory items trace to the documented invariant (never hardcode a user-facing string) and the First-Principles-Verdict: PASS Ten hardcoded English plural labels become locale-correct What this change shipsIntent: stop non-English locales rendering English plural glue at ten count-label sites — a FIX.
Supporting (not user-facing): catalog plural bases across 12 locales + Each new key has exactly one call site — expected for translation keys, not premature generalization. Zero option at any site = mixed-language text for non-English users (named harm). Remaining 7 hardcoded hits and the detector widening are deferred to #5818/#5832, so no unfixed sibling rides here. [FIRST-PRINCIPLES-REVIEWED] 94342b3 |
Opus 4.8 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
github-actions
Bot
added
readiness: action required
Ten user-visible sites still built their count labels with fully hardcoded
template-literal plural glue (`${n} issue${n === 1 ? '' : 's'}`) or its
uninflected sibling (`${n} more`) — the label assembled in JS, in English,
entirely outside any translate call — so every non-English locale rendered
mixed-language text. Sites converted, per the pattern PR #5811 established:
- App.tsx: the nav overflow toggle's "Show N more apps" title and its visible
"N more" label, and the notification bell's "N notifications" title
- AppsPage.tsx: the "Updated N apps." success message
- issue-radar TaggingView: the "Labelled N issues[; M could not be updated]"
banner (both branches) and the "Apply N suggestions" button
- issue-radar LabelsPanel: the "N open issues" chip title, in both its
with-description and no-description branches
- issue-radar PrList: the "N files changed" diff-stat title
- file-explorer SearchPanel: the "N results" status line and its "(capped)"
truncation suffix
Each site now passes the count into one i18nT(key, { count }) call. The
SearchPanel count reuses the existing components.discoverySearchBar.result
base rather than duplicating it (both sites carry a shared-owner note); the
other sites add ten new plural bases with per-language plural forms across
all 12 catalogs (categories exactly per each language's own Intl.PluralRules:
ru 4 forms, es/fr/it/pt 3, en/de/hi/bn 2, zh-CN/ja/ko 1), registered in
pluralKeys.json, plus one plain key, with en-XA regenerated.
The nav overflow toggle's accessible name now equals its visible label while
the label is shown (WCAG 2.5.3 Label in Name): converting only the aria-label
would have localized the name while the visible text stayed English, letting
the two diverge in every non-English locale. Its title keeps the fuller
"Show N more apps" phrasing for icon-only (collapsed) mode.
The [plurals-hardcoded] growth-only ceiling ratchets down 37 -> 7, the count
the gate itself reports after the conversion (the detector lib is untouched;
widening it is #5818 / PR #5832).
The remaining detector hits are model-directed prompt text (CommentOverlay,
ArtifactDetailPage, design-tweak prompts), which is deliberately English and
not user-visible locale copy.
Closes #5820
f88fb88 to
94342b3
Compare
github-actions
Bot
added
readiness: checking
github-actions
Bot
removed
the
readiness: passed
2 participants
Summary
Ten user-visible sites still built count labels with fully hardcoded template-literal plural glue (
${n} issue${n === 1 ? '' : 's'}) or its uninflected sibling (${n} more) — the plural decision made in JS, in English, outside any translate call — so every non-English locale rendered mixed-language text. This is the follow-up conversion pass that issue #5820 enumerated after PR #5811 merged; the conversion follows #5811's pattern exactly.Converted sites (each now one
i18nT(key, { count })call):App.tsxnav overflow toggleApp.tsxnotification bellAppsPage.tsxTaggingViewLabelsPanelPrListSearchPanelCatalog changes: ten new plural bases across all 12 catalogs with categories exactly per each language's own
Intl.PluralRules(ru 4 forms, es/fr/it/pt 3, en/de/hi/bn 2, zh-CN/ja/ko 1), registered inpluralKeys.json, plus one plain key;en-XAregenerated. The SearchPanel count reuses the existingcomponents.discoverySearchBar.resultbase instead of duplicating it (shared-owner notes at both sites).WCAG 2.5.3 (Label in Name): the nav overflow toggle's accessible name now equals its visible label while the label is shown; converting only the
aria-labelwould have localized the name while the visible text stayed English, letting the two diverge in every non-English locale. Collapsed (icon-only) mode keeps the fuller "Show N more apps" name.Ceiling:
[plurals-hardcoded]ratchets down 37 → 7, the count the gate itself reports post-conversion. The detector lib is untouched — widening it is #5818 / PR #5832. The remaining 7 hits are model-directed prompt text (CommentOverlay, ArtifactDetailPage, design-tweak prompts), deliberately English.Screenshots
Real
SearchPanelcomponent (mocked search seam only), result count through the converted key:English rendering is byte-identical at every converted site (verified per-site against the old ternaries, including the 0-count and 1-count edges).
Testing
node scripts/i18n-check.mjsexit 0 —[plurals]hard zero,[plurals-hardcoded]7 at ceiling 7, pseudolocale parity, key-refs, DNT, manifest-sync all greennpx tsc -bcleannpx vitest run: 24120 passed; the single failure issrc/i18n/style/hiStyle.test.tswhich fails identically on pristine main (introduced by fix(i18n): confirm bodies lead with consequence, one discard verb (#5243) #5529'sआपकेin a papyrus key; unblocker PRs fix(i18n): reword the co-author discard confirm to informal Hindi register #5850/fix(i18n): use informal tone in the papyrus co-author discard confirm (hi) #5853 are already open) — inherited, not from this diffUpdated 1 app.,1 file changed/3 files changed,/Labelled 2 issues/,/Apply N suggestions?/,findByTitle(/more app/i)notification_countrename, shared-key notes) are all adoptedCloses #5820