e2e: firecracker parity round 2 — environment, sizing, crash-loop - #213
Merged
Conversation
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firecracker goes from 9 to 13 e2e tests, closing the gaps that mattered most against Cloud Hypervisor's 24.
What was added
t12_environment.sh— environment variables must reach the NoCloud cidata payload. CH covers this (t4); Firecracker did not, despite sharing the cloud-init path. Env vars are how most workloads get configured, so "the VM booted" proves nothing if the config never arrived. Also asserts a value containing spaces survives intact — the case that breaks naiveKEY=valueemitters — and that the cidata image is reaped on delete.t13_resource_limits.sh—resources.limitsmust reach the microVM's machine config. This reads Firecracker's own/machine-configover its API socket, so it checks what the hypervisor actually got rather than what Ring intended to send. Firecracker's sizing rules differ from CH's and are easy to break silently:1500m→ 2 vCPUs), where CH rounds downt14_crashloop.sh— a deployment that cannot boot must land inCrashLoopBackOffrather than retrying forever. On a VM runtime that is not cosmetic: every attempt copies a rootfs and allocates a TAP, so an unbounded loop eats disk and network interfaces until the host gives out. Asserts the terminal state, that artifacts stop accumulating after it, and that the failure is explained in the events.A bug in my own earlier test, now fixed
t11_health_checks.shshipped in #212 with theon_failure: alertassertion removed, and a comment saying the alert "does not fire reliably within the window".That was wrong.
ring deployment eventsrenders a table and has no--output jsonflag, so myjqfilter was silently parsing tabular text and always yielding nothing. The alert fires within seconds, exactly as designed. The assertion is restored, using the command's own--levelfilter, and the board task tracking the phantom anomaly is closed.Worth knowing for anyone writing e2e against this CLI:
deployment health-checkssupports--output json,deployment eventsdoes not.Verification
firecracker t1, t9, t10, t11, t12, t13, t14 all run and pass locally against real microVMs.