e2e: cover podman logs and metrics - #214
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Podman goes from 5 to 6 e2e tests, covering the two things that make a runtime observable: logs and metrics.
What was added
t6_podman_logs_metrics.sh—ring deployment logsreturns the container's stdout,--tail Nactually bounds the output, andring deployment metricsreports real per-instance figures.Podman shares Docker's lifecycle code but not its daemon: logs and stats travel over Podman's Docker-compatible API, rootless, through a different socket. "It works on Docker" says nothing about whether that compatibility layer returns what Ring expects — and a runtime whose logs or metrics come back empty is effectively unobservable.
The memory assertion checks both that usage is non-zero (a real cgroup read, not a placeholder) and that the manifest's
64Milimit is reflected back — which proves the limit reached the container and that Ring reads it from the runtime rather than echoing the manifest. Observed:400.00 KiB / 64.00 MiB (0.6%).A trap worth knowing about
Only three deployment subcommands accept
--output json:--output jsonlist,inspect,health-checksmetrics,events,logsPassing
--output jsonto a text command is not always a hard error, and piping rendered text throughjqyields nothing silently — which reads exactly like "the feature is broken". That mis-diagnosis cost me two false conclusions in this suite: first that Firecracker'son_failurealert did not fire (it does, fixed in #213), then that Podman reported no metrics at all (it does).Documented at the top of
tests/e2e/lib.shso the next person writing assertions does not repeat it.Verification
podman t1–t6 all run and pass locally against a real rootless Podman socket.