Skip to content

ci(go): read toolchain from go.mod - #14

Open
kcrmin wants to merge 2 commits into
mainfrom
ci/go-toolchain-from-go-mod
Open

kcrmin wants to merge 2 commits into
mainfrom
ci/go-toolchain-from-go-mod

Conversation

@kcrmin

@kcrmin kcrmin commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Objective

The scheduled Security workflow has failed every Monday since 2026-10-12 on the
unchanged main commit. govulncheck reports Go standard library advisories
fixed after go1.26.6, the version pinned in seven setup-go steps.

Change

  • cli/go.mod: add toolchain go1.26.11 (latest 1.26 patch). The go 1.26.0
    language floor is unchanged.
  • ci.yml, release.yml, security.yml: replace go-version: 1.26.6 with
    go-version-file: cli/go.mod. The pinned setup-go (v6.5.0) reads the
    toolchain directive, so the next Go security release is a one-line bump.
  • ci.yml: the macOS ARM64 job moves from macos-14 to macos-15. GitHub
    retired the macos-14 image on 2026-11-02
    (https://github.blog/changelog/2026-10-01-github-actions-macos-14-runner-image-retirement),
    so the job was rejected before it started on any pull request.
    validate_ci_test.py and validate_release_config.py now expect macos-15.

Evidence (local, darwin/arm64)

  • govulncheck ./... v1.6.0 on go1.26.6: exit 3, 9 standard library
    vulnerabilities (GO-2026-6859, 6809, 6617, 6613, 6612, 6611, 6608, 6607, 6603).
  • Same on go1.26.11: exit 0, no vulnerabilities.
  • go1.26.11: go build ./..., go vet ./... and go test ./... pass.
  • validate_release_config.py, validate_docs.py, validate-plugin.sh and
    security_scan.py . pass.
  • validate_ci_test.py fails with macos-14 in ci.yml and passes with
    macos-15.

Conflict scope and merge order

Only Go toolchain selection and the macOS runner label change. #13 also edits
these workflows and still pins go-version: 1.26.6 and macos-14; whichever
merges second should use go-version-file: cli/go.mod and macos-15.

Risk and rollback

  • Changing go.mod makes this PR run the dependency-review step.
  • Local Go older than 1.26.11 switches to go1.26.11 under the default
    GOTOOLCHAIN=auto; newer local toolchains are used as is.
  • Roll back by reverting this commit.

Generated changes

None.

Follow-up

v1.0.0 binaries were built with go1.26.5. A release built from this commit is
needed to ship the patched standard library.

Weekly govulncheck fails on stdlib advisories fixed after go1.26.6.
Pin go1.26.11 once in cli/go.mod and point setup-go at it.
GitHub retired the macos-14 image on 2026-11-02, so the macOS ARM64
job was rejected before it started.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant