Repository navigation
Conversation
Weekly govulncheck fails on stdlib advisories fixed after go1.26.6. Pin go1.26.11 once in cli/go.mod and point setup-go at it.
GitHub retired the macos-14 image on 2026-11-02, so the macOS ARM64 job was rejected before it started.
Check filepath.IsLocal on archive entry names and reject C:foo style names on every platform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Close code scanning alert #1 (
go/zipslipincli/internal/ui/import.go) and clear thegolang.org/x/textadvisories GO-2026-6629 and GO-2026-5970.Change
filepath.IsLocalon the cleaned name, a check CodeQL recognises as a sanitizer. The drive-letter pattern now rejects drive-relative names such asC:fooon every platform, not onlyC:/foo.golang.org/x/textv0.14.0 -> v0.44.0 (indirect, via jsonschema).Stacked on #14 (Go toolchain from
go.mod). Merge #14 first; until then this diff also shows its two commits.Evidence
TestImportRejectsArchivePathsOutsideQuarantinecovers parent, nested parent, POSIX absolute, UNC, drive-absolute and drive-relative names. It failed for the three drive-relative cases before the fix and passes after.go test ./...,go vet ./..., govulncheck v1.6.0 (no vulnerabilities found),validate_docs.py,validate-plugin.sh,validate_release_config.pyandsecurity_scan.pyall pass.Risk and rollback
Archives with entries starting with a drive letter and colon, or (on Windows) reserved names or colons, are now rejected; none are valid quarantine paths. Roll back by reverting the two commits.