Repository navigation
📝 docs(msrv): 1.95 is a promise above the graph's 1.90 floor (#722) - #728
Merged
Merged
Conversation
The rationale for `rust-version = "1.95"` named `libsqlite3-sys` 0.38 and its use of the std `cfg_select!`. Since #720, `rusqlite` 0.41.1 brings `libsqlite3-sys` 0.39.1, which declares 1.88.0 and defines its own `cfg_select!`, so that reason no longer holds. Re-measured against the lockfile of 8e2eed2 on aarch64-apple-darwin, with `rust-version` set to the toolchain under test: `cargo +1.89 check --all-targets --locked` stops at cargo's gate on `ordered-float@5.5.0 requires rustc 1.90`, and `cargo +1.90` passes with and without default features. `ordered-float` comes in only through the `saphyr` dev-dependency, and 1.89 compiles every target once the gate is lifted, so the 1.90 is a declaration, not a language or std need. The declared floor stays at 1.95: lowering it would promise 1.90 to users on the strength of a test-only dependency. Cargo.toml, the stability policy (EN, FR), the msrv job comment, ROADMAP and the roadmap pages now say so; CHANGELOG gains a Docs entry.
Pre-merge checks:
|
…the msrv job (#722) Review of #728. `libsqlite3-sys` 0.38.2, which #585 brought in, already defined its own `cfg_select!` (0.38.1, the version #491 measured, used the std one), so the 1.95 rationale was stale from #585 on and #720 only added the declared 1.88.0. The msrv job comment, one of the three places #722 lists, now says what sets the graph's floor and points to Cargo.toml for the measurement. The measurement is qualified as macOS-only and the gate-lifted 1.89 run as default features only; CONTRIBUTING gets the same "kept since #722" as ROADMAP. The stability policy no longer gains a rule for lowering the floor: the PR corrects its explanation, it does not change the policy.
) Review of #728. The stability policy's MSRV section gained a rule ("may sit above what the graph needs, never below it") and Cargo.toml a procedure for lowering the floor; neither was asked for, and the PR body said the opposite. The section now keeps its original wording and only records the measurement and the decision, dated to #722. The changelog says the rules are unchanged. The msrv job comment qualifies the graph's floor as measured on macOS only; CONTRIBUTING and ROADMAP name 0.38.1, the version that actually raised the floor.
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
rust-version = "1.95"was justified bylibsqlite3-sys0.38.1, which declared no floor and used the stdcfg_select!(stable since 1.95.0). That reason was already stale from #585 on:libsqlite3-sys0.38.2 defines its owncfg_select!withmacro_rules!inbuild.rs(checked on the.cratefiles: 0.38.1 calls the std macro at build.rs:110/643, 0.38.2 and 0.39.1 define it at build.rs:11). #720 (#723) then broughtrusqlite0.41.1 /libsqlite3-sys0.39.1, which also declaresrust-version = "1.88.0". Nothing failed on the drift becausetests/msrv_tests.rspins the MSRV claims, not the rationale.This PR re-measures the floor by compiling, keeps the declared floor at 1.95, and corrects every explanation of it.
Closes #722
Measurement
Against the lockfile of
8e2eed25(devat branch time), on aarch64-apple-darwin,RUSTFLAGS=""like themsrvjob, withrust-versiontemporarily set to the toolchain under test (otherwise cargo's gate fires on gwm-cli's own1.95before reaching the graph), each toolchain installed with--profile minimaland a throwawayCARGO_TARGET_DIR:cargo +1.90 check --all-targets --lockedcargo +1.90 check --all-targets --locked --no-default-featurescargo +1.89 check --all-targets --lockedcargo +1.89 check --all-targets --locked --no-default-featurescargo +1.89 check --locked(lib + bins, whatcargo installbuilds)cargo +1.89 check --locked --no-default-featurescargo +1.89 check --all-targets --locked --ignore-rust-version(default features only)The 1.89 failure, verbatim, identical for both feature sets:
So the graph's floor under the
msrvjob's definition is 1.90, set only byordered-float5.5.0's declaredrust-version. It is reached throughsaphyr0.3.3, a[dev-dependencies]entry (cargo tree -i ordered-float@5.5.0 -e all), and the code compiles at 1.89 once the gate is lifted: no language or std feature needs 1.90. Highest declared floors in the resolve (cargo metadata --filter-platform) are the same on darwin, linux-gnu and windows-msvc:ordered-float5.5.0 at 1.90, thenrusqlite0.41.1 andserde-saphyr2.1.1 at 1.89. Linux and Windows were not compiled at 1.90 locally; they are bounded below by that platform-independent declaration and above by the green 1.95 job.Decision: keep 1.95
docs/6.development/3.stability.md§MSRV policy has no rule for lowering: it definesrust-versionas the floor the crate is expected to compile against (1.95 still is, themsrvjob holds it) and only ever describes bumps. The issue's own bar decides: lowering is a support promise, not a cleanup. A 1.90 promise would rest on a test-only dependencycargo installnever builds, and the nextsaphyr/ordered-floatrelease raising its floor would become an MSRV change (minor release + changelog) under that policy. So the floor stays, and the prose records the gap between the declared floor and what the graph needs as a dated decision, without turning it into a policy rule.Type of change
Changes
Cargo.toml: the comment aboverust-versionholds the measurement (the one place the numbers live in full), the oldlibsqlite3-sys0.38.1 reason moved to history, and the reason the floor is kept.docs/6.development/3.stability.mdanddocs/fr/…: one paragraph appended to §MSRV policy recording that the declared floor now sits above what the graph needs (on macOS), what ⬆️ chore(deps)(deps): bump rusqlite from 0.40.1 to 0.40.2 #585 and [Bug]: cargo audit red on dev: RUSTSEC-2026-0459 (libsqlite3-sys) and RUSTSEC-2026-0486 (rustix) #720 changed, the [Task]: re-measure the MSRV floor: libsqlite3-sys 0.39 no longer sets it #722 measurement and the keep decision. The policy's existing wording and rules are unchanged; no rule for lowering is added..github/workflows/ci.yml: themsrvjob comment sayslibsqlite3-sysdid declare nothing, up to 0.38, and that since [Task]: re-measure the MSRV floor: libsqlite3-sys 0.39 no longer sets it #722 the declared floor sits above the graph's, which, on macOS,ordered-float(through the test-onlysaphyr) sets; it points to Cargo.toml for the measurement. Comment only.CONTRIBUTING.md: the prerequisites line says the floor was raised bylibsqlite3-sys0.38.1 and kept since [Task]: re-measure the MSRV floor: libsqlite3-sys 0.39 no longer sets it #722 (thestable channel, 1.95+claim is unchanged).ROADMAP.md,docs/7.roadmap.md,docs/fr/7.roadmap.md: present-tense "declares no floor" claims aboutlibsqlite3-sysmoved to the past tense; ROADMAP names 0.38.1 and notes the floor is kept since [Task]: re-measure the MSRV floor: libsqlite3-sys 0.39 no longer sets it #722. The history lines ("the 1.95 bump came withlibsqlite3-sys") are still true and untouched.CHANGELOG.md: one entry under[Unreleased] / Docs.Tests
cargo testpasses locally (GWM_HISTORY_FILEpointed at a temp file): full suite on9249cca8, 3589 passed, 0 failed, 4 ignored (all pre-existing); after the review fixes, the 17 test binaries that read the edited files re-ran onfff1845a: 527 passed, 0 failed. CI onfff1845a: 15/15, the threemsrv (declared floor, …)jobs includedcargo fmt --checkpassescargo clippy -- -D warnings: not run, no Rust source touchedtests/: none. Exception argued: comments and docs only, no behaviour change.tests/msrv_tests.rskeeps pinning every live MSRV claim toCargo.toml(allLIVE_CLAIMSsubstrings are byte-identical) and themsrvjob still compiles the declared 1.95 on all three runners.Checklist
<type>/#<issue>-<description>## [Unreleased]examples/gwm.toml.exampleupdated if config schema changed: no schema changeunwrap()on user-facing paths (returnGwmErrorinstead)println!in TUI render code (status bar only)Linked issues / docs
Notes for reviewers
rust-versionitself does not move, so themsrvjobs still install 1.95: green there is the same check as ondev, not a test of the new prose.