Repository navigation
⬆️ chore(deps): bump rusqlite to 0.42.0 (#733) - #734
Merged
Merged
Conversation
The lock moves rusqlite (0.41.1 -> 0.42.0), libsqlite3-sys (0.39.1 -> 0.40.0) and the wasm-only sqlite-wasm-rs (0.5.5 -> 0.6.3) / rsqlite-vfs (0.1.1 -> 0.2.0), whose floor 0.42 raises to >=0.6.3; those two sit under cfg(all(target_family = "wasm", target_os = "unknown")) and never build on a native target. libsqlite3-sys 0.40.0 ships the same SQLite as 0.39.1: the amalgamation (3.54.1, same source id), build.rs and src/ are byte-identical; only the optional sqlcipher-src pin moves. The 0.42 fixes sit behind features gwm does not enable (session, collation, functions, vtab, array, sqlcipher) or calls it never makes (busy_handler, the hook setters). Declared rust-versions are unchanged (rusqlite 1.89, libsqlite3-sys 1.88). The MSRV comment says 0.41.1 "brought in" 0.39.1: it is no longer in the graph. refs #733
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps
rusqlite0.41.1→0.42.0. The SQLite compiled into gwm does not change, and none of the 0.42 fixes reach a code path gwm uses.Closes #733
Type of change
Changes
Cargo.toml:rusqlite = { version = "0.42.0", features = ["bundled"] }. One word of the MSRV comment goes to the past tense ("whichrusqlite 0.41.1brought in"), since 0.41.1 is no longer in the graph; the [Task]: re-measure the MSRV floor: libsqlite3-sys 0.39 no longer sets it #722 measurement it reports is left as recorded, not restated.Cargo.lock: four packages move, all forced byrusqlite0.42's requirements:rusqlite0.41.1 → 0.42.0libsqlite3-sys0.39.1 → 0.40.0.diff -rqof the two crate sources:sqlite3/(the amalgamation,SQLITE_VERSION "3.54.1", sameSQLITE_SOURCE_ID),build.rsandsrc/are byte-identical. What changes is the version, the optionalsqlcipher-srcpin (=419.0.6→=420.0.0, only withbundled-sqlcipher) and the SQLCipher bindings. The "bundled SQLite 3.54.1" line of the 0.42 release notes was already shipped by 0.39.1 ([Bug]: cargo audit red on dev: RUSTSEC-2026-0459 (libsqlite3-sys) and RUSTSEC-2026-0486 (rustix) #720).sqlite-wasm-rs0.5.5 → 0.6.3 andrsqlite-vfs0.1.1 → 0.2.0: 0.42 raises itssqlite-wasm-rsrequirement from>=0.5.1to>=0.6.3. Both sit undercfg(all(target_family = "wasm", target_os = "unknown"));cargo tree -i sqlite-wasm-rsprints nothing on the host and finds them only with--target wasm32-unknown-unknown. No second SQLite reaches the binary.CHANGELOG.md: entry under[Unreleased] > Dependencies.Why nothing else changes for gwm
Active
rusqlitefeatures (cargo tree -e features -i rusqlite):bundled,modern_sqlite,cache/hashlink,ffi-sqlite-wasm-rs(inert off wasm). gwm callsopen_with_flags(READ_ONLY | NO_MUTEX),prepare,query_map,Row::get,Row::get_refand matchesValueRef::Null(src/agent_sessions.rs::opencode_scan_db, plusConnection::open/execute/params!in tests). Between 0.41.1 and 0.42.0,row.rs,statement.rs,types/value_ref.rsandparams.rsare identical. The changed files map to features or calls gwm does not use:Session::apply/apply_strm(#1941)sessionfeature, offcollation/functions, offRawValue,InvalidParameterTypereplaces two error variants (#1933)functions/vtab, offrarrayordering (#1934)array, offsqlite3_key_v2/rekey_v2, SQLCipher 4.20.0, wasm SQLCipher (#1930, #1932, #1921)sqlcipher/codec, offset_clientdataon OOM (#1944), and the null-handler path inbusy.rsConnection::busy_handler/busy_timeoutand the hook setters; gwm calls none of them, andopen_with_flagssets its default timeout with a rawffi::sqlite3_busy_timeout(inner_connection.rs:90)cfg_select!uses inlib.rsmod test; rusqlite defines its ownmacro_rules! cfg_select(error.rs:11), as 0.41.1 didMSRV
No change. Declared floors:
rusqlite0.42.01.89.0(same as 0.41.1),libsqlite3-sys0.40.01.88.0(same as 0.39.1),sqlite-wasm-rs0.6.3 andrsqlite-vfs0.2.01.81.0(wasm only). The declaredrust-versionstays1.95. The graph floor of 1.90 recorded for #722 was not re-measured here; the C sources and build script it compiled are byte-identical, and no newly reached code declares above 1.89.third-party/No change. The bundled SQLite stays 3.54.1, and SQLite is public domain (a "blessing" in place of a license), so it carries no notice obligation. Pre-existing and out of scope here:
third-party/README.mdsays gwm links "two C libraries" statically, which leaves out the bundled SQLite.Tests
cargo testpasses locallycargo fmt --checkpassescargo clippy -- -D warningspasses (--all-targets)tests/(TDD: a PR adding behaviour without tests is sent back)TDD exception, per CLAUDE.md: dependency bump without behaviour change, CI green is the test. The existing opencode coverage exercises every
rusqlitecall gwm makes against a real SQLite file:agent_sessions_tests(opencode_scan_reads_the_sqlite_db_when_presentand siblings) andcli_binary(opencode_db_sessions_are_read_without_a_sqlite3_cli,opencode_detection_honors_xdg_data_home).Also run locally, exit codes read without pipes:
cargo audit --deny warnings: exit 0, noaudit.toml, noignorethird_party_notices_tests: greencargo test: exit 0, 112test result: oklines out of 112, 3594 passed, 0 failed, 4 ignored (pre-existing#[ignore])agent_sessions_tests72 passed,cli_binary opencode2 passedcargo +1.95 check --all-targets --locked(themsrvjob's command, throwaway target dir,RUSTFLAGS=""): exit 0, buildslibsqlite3-sys0.40.0Not run: the stripped-
PATHone-liner from CLAUDE.md. No env-dependent test is touched, and on this machine (macOS arm64) that one-liner fails at link time (library 'iconv' not found).Screenshots / TUI captures
n/a
Checklist
<type>/#<issue>-<description>## [Unreleased]examples/gwm.toml.exampleupdated if config schema changed (n/a)unwrap()on user-facing paths (returnGwmErrorinstead)println!in TUI render code (status bar only)Linked issues / docs
Notes for reviewers
unicode-widthstays held ([Task]: take unicode-width 0.2.3 together with the ratatui-core release that stops double-counting sound marks #721); nothing else rides along.msrvjobs are the check for the declared 1.95 floor against the new lock.