Repository navigation
move to stock nginx base image - #26
Conversation
move to stock nginx base image
Add module directive to load headers-more
update workflow to point to an available parent
| worker_processes auto; | ||
| pid /run/nginx.pid; | ||
|
|
||
| load_module modules/ngx_http_headers_more_filter_module.so; |
There was a problem hiding this comment.
This is needed because the stock nginx doesn't load the module by default (openresty must have).
There was a problem hiding this comment.
🟡 Changes recommended
The new NGINX image lacks Lua support while the shipped site template still uses Lua directives, causing affected deployments to fail at startup with unknown-directive errors.
1 open issue
What changed in this PR
This PR migrates the deployment proxy from OpenResty to the stock NGINX Alpine image while retaining the existing configuration layout.
Changes:
- Adds a multi-stage build to compile and install the headers-more module.
- Loads headers-more in the NGINX configuration template.
- Switches the reusable build workflow to
kbase-infra.
| File | Description |
|---|---|
Dockerfile |
Uses stock NGINX, builds headers-more, and preserves the deployment configuration path. |
deployment/conf/.templates/openresty.conf.templ |
Loads the headers-more dynamic module. |
.github/workflows/managed_build.yaml |
Uses the build-and-scan workflow from kbase-infra. |
Review effort: Balanced
There was a problem hiding this comment.
Moving off OpenResty makes sense now that Lua isn't needed. Three things should be fixed before merge: the base pin, the OpenResty path symlink and BuildKit (inline). Comments on files outside the diff:
- Delete
deployment/conf/.templates/minikb-narrative.templ. It is the only Lua left in the repo (content_by_lua,access_by_lua_block,proxymgr), and nothing references it. If anyone pointsnginx_site_cfgat it, nginx on the new image fails withunknown directive "content_by_lua". - Delete
hooks/build(and thehooks/directory). It is the legacy Docker Hub autobuild hook, nothing references it, and CI now builds through the reusable workflow. Left in place, it runs a plaindocker buildthat breaks on the newRUN --mount. - Pre-existing:
openresty.conf.templstill hasssl_protocols TLSv1 TLSv1.1 TLSv1.2;. Since this branch is a CVE fix, consider changing it toTLSv1.2 TLSv1.3. OpenSSL 3 refuses 1.0/1.1 at the default security level anyway.
changes suggested by AI
Unnecessary delete suggested by AI
Use full path to modules as suggested by AI
Delete unused file suggested by AI
Changes suggested by AI

move to stock nginx base image