Skip to content

move to stock nginx base image - #26

Merged
kkellerlbl merged 9 commits into
masterfrom
CVE-2026-123007
Nov 20, 2026
Merged

kkellerlbl merged 9 commits into
masterfrom
CVE-2026-123007

Conversation

@kkellerlbl

Copy link
Copy Markdown
Member

move to stock nginx base image

move to stock nginx base image
Add module directive to load headers-more
update workflow to point to an available parent
worker_processes auto;
pid /run/nginx.pid;

load_module modules/ngx_http_headers_more_filter_module.so;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed because the stock nginx doesn't load the module by default (openresty must have).

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new NGINX image lacks Lua support while the shipped site template still uses Lua directives, causing affected deployments to fail at startup with unknown-directive errors.

1 open issue
What changed in this PR

This PR migrates the deployment proxy from OpenResty to the stock NGINX Alpine image while retaining the existing configuration layout.

Changes:

  • Adds a multi-stage build to compile and install the headers-more module.
  • Loads headers-more in the NGINX configuration template.
  • Switches the reusable build workflow to kbase-infra.
File Description
Dockerfile Uses stock NGINX, builds headers-more, and preserves the deployment configuration path.
deployment/​conf/​.templates/​openresty.conf.templ Loads the headers-more dynamic module.
.github/​workflows/​managed_build.yaml Uses the build-and-scan workflow from kbase-infra.

Review effort: Balanced

Comment thread Dockerfile Resolved

@bio-boris bio-boris left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving off OpenResty makes sense now that Lua isn't needed. Three things should be fixed before merge: the base pin, the OpenResty path symlink and BuildKit (inline). Comments on files outside the diff:

  • Delete deployment/conf/.templates/minikb-narrative.templ. It is the only Lua left in the repo (content_by_lua, access_by_lua_block, proxymgr), and nothing references it. If anyone points nginx_site_cfg at it, nginx on the new image fails with unknown directive "content_by_lua".
  • Delete hooks/build (and the hooks/ directory). It is the legacy Docker Hub autobuild hook, nothing references it, and CI now builds through the reusable workflow. Left in place, it runs a plain docker build that breaks on the new RUN --mount.
  • Pre-existing: openresty.conf.templ still has ssl_protocols TLSv1 TLSv1.1 TLSv1.2;. Since this branch is a CVE fix, consider changing it to TLSv1.2 TLSv1.3. OpenSSL 3 refuses 1.0/1.1 at the default security level anyway.

Comment thread Dockerfile Resolved
Comment thread Dockerfile Resolved
Comment thread Dockerfile Resolved
Comment thread .github/workflows/managed_build.yaml Resolved
Comment thread Dockerfile Resolved
changes suggested by AI
Unnecessary delete suggested by AI
Use full path to modules as suggested by AI
Changes suggested by AI
@kkellerlbl
kkellerlbl requested a review from bio-boris November 20, 2026 00:15
@kkellerlbl kkellerlbl self-assigned this Nov 20, 2026
@kkellerlbl
kkellerlbl merged commit b32ce93 into master Nov 20, 2026
1 check passed
@kkellerlbl
kkellerlbl deleted the CVE-2026-123007 branch November 20, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants