Repository navigation
Conversation
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
Deployment startup and template-rendering arguments and consumers of the removed endpoints are outside this repository, requiring a deployment owner to validate the stock-nginx rollout and endpoint retirement against the live deployment contract.
No open issues 🎉
What changed in this PR
Migrates the deployment proxy from OpenResty to stock nginx, removing obsolete Lua-backed functionality and updating the configuration for nginx compatibility.
Changes:
- Switches to the official
nginx:alpineimage and removes OpenResty-specific setup and dependencies. - Removes Lua-backed proxy management, narrative routing, and session handling.
- Uses
listen 443 ssland removes deprecated standalone SSL directives.
| File | Description |
|---|---|
Dockerfile |
Switches the base image and simplifies dependencies and nginx filesystem setup. |
deployment/conf/.templates/minikb-narrative.templ |
Removes obsolete Lua handlers and updates SSL listener syntax. |
Review effort: Balanced
Member
|
I suspect this image won't work, since AFAICT it doesn't include the headers-more module. See #26 for a solution that may work better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
nginx -twith a temporary certificate and isolated DNS.