Skip to content

Replace OpenResty with stock nginx - #25

Closed
bio-boris wants to merge 1 commit into
masterfrom
copilot/stock-nginx
Closed

bio-boris wants to merge 1 commit into
masterfrom
copilot/stock-nginx

Conversation

@bio-boris

Copy link
Copy Markdown
Contributor

Summary

  • Switch the image to the official nginx Alpine base and update the HTTPS listener configuration.
  • Remove obsolete Lua-backed proxy manager, narrative routing, and session handling.

Validation

  • Built the Docker image.
  • Rendered both templates and ran nginx -t with a temporary certificate and isolated DNS.

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 19, 2026 21:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Deployment startup and template-rendering arguments and consumers of the removed endpoints are outside this repository, requiring a deployment owner to validate the stock-nginx rollout and endpoint retirement against the live deployment contract.

No open issues 🎉

What changed in this PR

Migrates the deployment proxy from OpenResty to stock nginx, removing obsolete Lua-backed functionality and updating the configuration for nginx compatibility.

Changes:

  • Switches to the official nginx:alpine image and removes OpenResty-specific setup and dependencies.
  • Removes Lua-backed proxy management, narrative routing, and session handling.
  • Uses listen 443 ssl and removes deprecated standalone SSL directives.
File Description
Dockerfile Switches the base image and simplifies dependencies and nginx filesystem setup.
deployment/​conf/​.templates/​minikb-narrative.templ Removes obsolete Lua handlers and updates SSL listener syntax.

Review effort: Balanced

@kkellerlbl

Copy link
Copy Markdown
Member

I suspect this image won't work, since AFAICT it doesn't include the headers-more module. See #26 for a solution that may work better.

@bio-boris bio-boris closed this Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants