Skip to content

fix(controller): move a ModelConfig condition's transition time only on a status change (v1.0.x backport) #3601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EItanya wants to merge 1 commit into from
Closed

fix(controller): move a ModelConfig condition's transition time only on a status change (v1.0.x backport) #3601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 14 additions & 16 deletions go/core/internal/controller/reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,26 +540,24 @@ func (r *Reconciler) reconcileModelConfigStatus(ctx context.Context, key string)
}

func statusWithTransitionTimes(desired, current kagentv1alpha3.AgentStatus) kagentv1alpha3.AgentStatus {
desired.Conditions = append([]metav1.Condition(nil), desired.Conditions...)
for i := range desired.Conditions {
condition := &desired.Conditions[i]
previous := apimeta.FindStatusCondition(current.Conditions, condition.Type)
if previous != nil && previous.Status == condition.Status {
condition.LastTransitionTime = previous.LastTransitionTime
} else {
condition.LastTransitionTime = metav1.Now()
}
}
desired.Conditions = conditionsWithTransitionTimes(desired.Conditions, current.Conditions)
return desired
}

func modelConfigStatusWithTransitionTimes(desired, current kagentv1alpha3.ModelConfigStatus) kagentv1alpha3.ModelConfigStatus {
desired.Conditions = append([]metav1.Condition(nil), desired.Conditions...)
for conditionIndex := range desired.Conditions {
condition := &desired.Conditions[conditionIndex]
if previous := apimeta.FindStatusCondition(current.Conditions, condition.Type); previous != nil &&
previous.Status == condition.Status && previous.Reason == condition.Reason &&
previous.Message == condition.Message && previous.ObservedGeneration == condition.ObservedGeneration {
desired.Conditions = conditionsWithTransitionTimes(desired.Conditions, current.Conditions)
return desired
}

// conditionsWithTransitionTimes keeps the transition time a condition's
// status holds and stamps the current time when the status changes, as
// apimeta.SetStatusCondition does; a new reason or message alone is no
// transition.
func conditionsWithTransitionTimes(desired, current []metav1.Condition) []metav1.Condition {
desired = append([]metav1.Condition(nil), desired...)
for conditionIndex := range desired {
condition := &desired[conditionIndex]
if previous := apimeta.FindStatusCondition(current, condition.Type); previous != nil && previous.Status == condition.Status {
condition.LastTransitionTime = previous.LastTransitionTime
continue
}
Expand Down
18 changes: 18 additions & 0 deletions go/core/internal/controller/reconciler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,3 +613,21 @@ func reconciliationTestCard(name string) *a2apb.AgentCard {
SupportedInterfaces: []*a2apb.AgentInterface{{Url: "http://127.0.0.1:80", ProtocolBinding: "GRPC", ProtocolVersion: "1.0"}},
}
}

func TestModelConfigConditionTransitionTimesMoveOnlyOnStatusChange(t *testing.T) {
then := metav1.NewTime(time.Date(2026, 1, 1, 0, 0, 0, 0, time.UTC))
current := kagentv1alpha3.ModelConfigStatus{Conditions: []metav1.Condition{
{Type: "Accepted", Status: metav1.ConditionFalse, Reason: "SecretNotFound", Message: "secret team-a/a not found", ObservedGeneration: 1, LastTransitionTime: then},
{Type: "Ready", Status: metav1.ConditionTrue, Reason: "Resolved", ObservedGeneration: 1, LastTransitionTime: then},
}}
desired := kagentv1alpha3.ModelConfigStatus{Conditions: []metav1.Condition{
{Type: "Accepted", Status: metav1.ConditionFalse, Reason: "SecretKeyNotFound", Message: "key missing in secret team-a/b", ObservedGeneration: 2},
{Type: "Ready", Status: metav1.ConditionFalse, Reason: "Unresolved", ObservedGeneration: 2},
}}

got := modelConfigStatusWithTransitionTimes(desired, current)

require.Equal(t, then, got.Conditions[0].LastTransitionTime, "a new reason, message or generation alone is no transition")
require.True(t, got.Conditions[1].LastTransitionTime.After(then.Time), "a status change stamps a new transition time")
require.True(t, desired.Conditions[0].LastTransitionTime.IsZero(), "the desired conditions are not mutated")
}
Loading