Repository navigation
Conversation
…on a status change (#3340) ## Problem The ModelConfig status writer moves a condition's `lastTransitionTime` whenever its reason, message or observedGeneration changes. Agent conditions, and SandboxTemplate through `apimeta.SetStatusCondition`, move it only when the status changes, as the API conventions define it. A ModelConfig that stays `False` therefore reports a new transition time every time its error text or generation changes. ## Change Agent and ModelConfig share one helper that keeps the transition time while a condition's status holds. A new test covers a changed reason, message and generation under an unchanged status, and a status change. This PR previously wrote Harness `Ready`/`Booted` conditions; #3454 removed `Harness.status`, so it is reduced to the transition-time rule that part shared with Agent and ModelConfig. Signed-off-by: QuentinBisson <quentin@giantswarm.io> (cherry picked from commit 347acbe) Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
This was referenced Nov 9, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #3340 (
347acbe55) torelease/v1.0.xwithout modifications.Stacked on
backport/v1.0.x/05-3563. Merge it after the PR below it in the stack.Stack (merge in order, bottom first):
🤖 Generated with Claude Code