Repository navigation
ci: check links with lychee, fix 27 broken Billomat doc links - #79
Merged
Merged
Conversation
- New Links workflow: lychee checks docs/, the root Markdown files and the Billomat links in docblocks and codegen definitions, on PRs, on pushes to 4.x and weekly. Config in lychee.toml. - 27 docblock links pointed to retired English pages (410) or guessed paths (404); they now use the German pages from docs/spec/billomat.json. - The recurring email receiver test comment no longer claims Billomat needs action=EMAIL for receivers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last CI item before 4.0.0-beta.1.
Changes
.github/workflows/links.yml, configlychee.toml): lychee checksdocs/**/*.md, the root Markdown files and the links insrc/docblocks andtools/codegen/definitions/. Runs on PRs touching them, on pushes to4.xand weekly (Monday 06:00 UTC) for link rot.GITHUB_TOKENavoids GitHub's rate limit; the result cache is kept between runs; 429 counts as reachable; example.com andmycompany.billomat.netplaceholders are excluded./en/api/confirmations/comments/etc. → 410) and some paths were guessed (/api/abo-rechnungen/email-empfaenger/→ 404). They now point to the German pages listed indocs/spec/billomat.json; confirmation and delivery note sub-resources have no page of their own, so they link to the parent page.canManageRecurringEmailReceiversInSandboxno longer claims receivers needaction=EMAIL(seeding showed Billomat accepts them withCREATE).Test plan
generate:check, PHPStan, lint, docs build