Repository navigation
ci: BC check against the latest 4.x tag; log retries at info - #74
Merged
Merged
Conversation
…ies at info - New CI job runs roave/backward-compatibility-check against the latest v4.* tag (informational until 4.0.0-beta.1). The Rector rules are baselined: their parent class lives in Rector's scoped PHAR and cannot be reflected. - Retries are logged at info instead of warning, so a retry that succeeds no longer trips alerting that fires at warning. Final failures keep their levels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backward compatibilityjob runs roave/backward-compatibility-check against the latestv4.*tag and reports findings as annotations. It is informational (continue-on-error) until 4.0.0-beta.1, then it becomes blocking. The tool is installed globally because it needs Symfony 7 components while our dev dependencies are on Symfony 8..roave-backward-compatibility-check.xml: the five Rector rules are ignored because their parentRector\\Rector\\AbstractRectorlives in Rector's scoped PHAR and BetterReflection can't locate it (not even with--install-development-dependencies). They are upgrade tooling, not runtime API.v4.0.0-alpha.1there are no other findings. Verified that a real break is caught: renamingMoney::toString()in a throwaway commit reported[BC] REMOVED: Method Justpilot\\Billomat\\Model\\Money#toString() was removedwith exit code 3.infoinstead ofwarning. Found while migrating a production app to 4.0 alpha: its Monolog sends alert mails from WARNING on, so it had to drop the SDK logger entirely. A retry that succeeds is expected behaviour; final failures keepnotice(4xx) anderror(5xx, network).Docs:
docs/testing.md(CI jobs, running the check locally),docs/configuration.md(log level table), AGENTS.md, CHANGELOG.Test plan
composer test, PHPStan, lintv4.0.0-alpha.1, real break detected