Return PR #126 review fix to main

[joefeser]

Returns the exact review fix selected from PR #126 to main without merging unrelated dev history.

Exact Provenance

• Base: origin/main @ dd8a12430467617cb10768e1b17bea033594dec2
• Selected reviewed source commit: 5c27a856d325eb013fe4198b7fe01fb2ad928578
• Main-based cherry-pick: 75c07b28859a961f863da9b75e0e574c12c9f7b4
• Selected and cherry-picked tree: 28e13ed8847cb668f538b0504d08dd3b2fb4b194
• Deliberately excluded: dev merge commit 214d947f9f2fb8082940811c206544d90914d296 and all unrelated ranges.

Scope

• Clarify that ranked-search warm-up removes process-scoped caches and cold operating-system pages while both timed modes retain the same fresh-connection cost.
• Exercise all five real slice runners with a failed projection-operation receipt and prove each emits a schema-valid failed receipt with at least one failed operation.

Security Impact

• No new execution, disclosure, credential, network, shell, or authority behavior.
• Synthetic test data only; no private vault material or machine-local resolver state.

Compatibility Impact

• No schema, API, CLI, fixture, or published compatibility change.
• The patch changes one benchmark explanation and adds implementation-level failure-path tests.

Validation

• 640 repository tests pass.
• Public JSON and contract validation pass.
• Full conformance suite passes.
• Public-safety scan passes.
• Seven-runtime SQLite matrix passes with no invariant failures.
• Cherry-picked tree exactly matches the selected reviewed source commit.

Merge Policy

• Merge commit only; do not squash or force-push.
• Apply any authorized review fixes only to this branch.

Summary by Sourcery

Clarify ranked-search timing semantics and strengthen slice failure-receipt validation.

Enhancements:

• Clarify ranked-search benchmark warm-up behavior and per-call connection costs.
• Add failure-path coverage for all five slice runners, verifying schema-valid failed receipts with failed operations.

Tests:

• Exercise projection and post-projection failures across the projection integrity and search slice runners.

[sourcery-ai]

Reviewer's Guide

Returns only the reviewed PR #126 fix to main: it makes ranked-search benchmark warm-up semantics precise and adds parameterized implementation-level tests proving all five slice runners produce schema-valid failed receipts when projection fails. No production behavior, schema, API, or compatibility surfaces are changed.

Sequence diagram for ranked-search benchmark warm-up and timing

sequenceDiagram
    participant Benchmark
    participant SearchAPI
    participant OS

    Benchmark->>SearchAPI: _warm_search_modes(index, query)
    SearchAPI->>OS: warm operating-system pages
    Benchmark->>SearchAPI: search_records(index, query)
    SearchAPI->>OS: open fresh connection
    Benchmark->>SearchAPI: search_records(index, query, rank=true)
    SearchAPI->>OS: open fresh connection
    loop timed modes
        Benchmark->>SearchAPI: _median_ms(action, repeats)
        SearchAPI->>OS: open fresh connection per call
    end

Loading

Flow diagram for projection-failure receipt coverage

flowchart LR
    A[Projection operation fails] --> B[Run each of five real slice runners]
    B --> C[Emit failed receipt]
    C --> D[Schema-valid receipt]
    C --> E[At least one failed operation]

Loading

File-Level Changes

Change	Details	Files
Clarifies which costs ranked-search warm-up removes and which costs remain in timed calls.	Updates the warm-up documentation to distinguish process-scoped caches and OS page faults from per-call connection setup. Documents that both ranked and unranked timed modes use the public API and retain fresh-connection overhead.	scripts/measure_ranked_search.py
Adds failure-path coverage for every real slice runner, including schema and outcome assertions.	Mocks projection to return failed results across all five slice implementations. Verifies each runner emits a failed top-level receipt containing at least one failed operation. Validates every generated receipt against its corresponding versioned schema.	tests/test_projection_integrity_slice.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[qodo-code-review]

PR Summary by Qodo

Validate failed slice receipts and clarify search warm-up

🧪 Tests 📝 Documentation 🕐 10-20 Minutes

AI Description

• Clarifies benchmark warm-up while preserving equal fresh-connection costs across search modes.
• Verifies five slice runners emit schema-valid receipts when projection reports failure.

Diagram

sequenceDiagram
    participant T as Failure Test
    participant F as Fixture Set
    participant R as Five Runners
    participant P as Projection Mock
    participant V as Schema Validator
    T->>F: Select slice fixture
    T->>R: Run with workspace
    R->>P: Project records
    P-->>R: Return failed outcome
    R-->>T: Emit failed receipt
    T->>V: Validate matching schema
    V-->>T: Accept receipt

Loading

High-Level Assessment

The table-driven test is the appropriate approach because it exercises all five real runners consistently while mocking only the shared projection boundary. Schema-only mutation tests would not verify runner behavior, while separate per-runner tests would duplicate setup without improving coverage.

Files changed (2) +59 / -1

Tests (1) +55 / -0

test_projection_integrity_slice.pyTest failed receipts across all slice runners +55/-0

Test failed receipts across all slice runners

• Adds a table-driven test covering five real slice runners with their synthetic fixtures and matching schemas. Each runner receives a projection receipt forced to a failed outcome, then must emit a top-level failed receipt containing a failed operation that passes schema validation.

tests/test_projection_integrity_slice.py

Documentation (1) +4 / -1

measure_ranked_search.pyClarify ranked-search warm-up semantics +4/-1

Clarify ranked-search warm-up semantics

• Explains that warm-up removes process-scoped validation and schema cache costs plus cold operating-system pages. It explicitly notes that both timed search modes still open fresh connections and therefore retain equal per-call connection overhead.

scripts/measure_ranked_search.py

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can turn these tips off under Display preferences

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[joefeser]

@codex review

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-10T19:52:05.276139Z	a094acf	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 75c07b2885

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[sourcery-ai]

Sourcery assessment

Approved.

[joefeser]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: a094acfdd2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".