Skip to content

Reconcile main snapshot b5af62303a38 into dev - #128

Merged
joefeser merged 4 commits into
devfrom
codex/reconcile-main-b5af62303a38-to-dev
Sep 10, 2026
Merged

Reconcile main snapshot b5af62303a38 into dev#128
joefeser merged 4 commits into
devfrom
codex/reconcile-main-b5af62303a38-to-dev

Conversation

@joefeser

@joefeser joefeser commented Sep 10, 2026

Copy link
Copy Markdown
Owner

Purpose

Reconcile the exact reviewed main snapshot back into dev after PRs #126 and #127 produced equivalent work on divergent histories.

Exact provenance

  • Source origin/main: b5af62303a38a19dd78cbe4d8e5cdcced61e1b89
  • Target origin/dev: 214d947f9f2fb8082940811c206544d90914d296
  • Reconciliation head: a055df8038369318a9ea109fcbe34c80b736e255
  • Reconciliation parents: exact source main, then exact target dev
  • Source and reconciliation tree: c39106c65b3345c090de50004530f588ff4ee244

The reconciliation commit records dev ancestry while intentionally preserving the exact main tree. No content patch was made on this sync branch.

Effective content change in dev

The only effective target-tree change is the corrected tests/test_projection_integrity_slice.py already reviewed and merged through PR #127. It replaces an impossible mocked failure with coverage of the real projection-construction and post-projection verification failure boundaries.

Validation

  • Focused projection-integrity slice: 4 tests passed.
  • Full repository suite: 641 tests passed.
  • Public safety: passed across 362 commits, 4,651 historical objects, and 641 current paths.
  • Reconciliation tree is byte-identical to exact merged main.

Security impact

No runtime, credential, authority, storage, or disclosure behavior changes. This PR carries only the already-reviewed test correction and reconciles branch ancestry.

Compatibility impact

No schema, protocol, package, context-pack, or runtime compatibility change. Merge commit required; do not squash.

Review scope

Review the exact resulting tree and ancestry reconciliation. Do not add advisory cleanup or unrelated patches to this synchronization branch; defer any new work to a later issue or feature branch.

Summary by Sourcery

Reconcile the reviewed main snapshot into dev and retain corrected integrity-slice failure coverage.

Bug Fixes:

  • Correct projection-integrity slice tests to cover genuine projection-construction and post-projection verification failures.

Enhancements:

  • Reconcile the reviewed main tree into dev while preserving the target branch ancestry.

Tests:

  • Expand failure-path coverage across projection and search slice runners, including schema-valid failed receipts and unhandled projection failures.

@sourcery-ai

sourcery-ai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Reviewer's Guide

This synchronization PR reconciles the exact reviewed main snapshot into dev, retaining dev ancestry through a merge commit while preserving main’s tree. Its only effective content change is the previously reviewed projection-integrity test correction, with no runtime, compatibility, security, or schema behavior changes.

File-Level Changes

Change Details Files
Reconciled the reviewed main snapshot into dev while preserving the exact main content tree and recording dev ancestry.
  • Created a merge reconciliation with exact main and dev parents.
  • Preserved the byte-identical main tree without introducing a new content patch.
  • Requires retaining the merge commit rather than squashing.
Reconciliation merge commit (a055df8038369318a9ea109fcbe34c80b736e255)
Corrected projection-integrity test coverage to exercise real projection and post-projection failure boundaries.
  • Verified projection-construction failures propagate without emitting slice receipts.
  • Injected representative post-projection failures across all five slice runners.
  • Validated failed receipts against their schemas and required failed operation outcomes.
tests/test_projection_integrity_slice.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@joefeser

Copy link
Copy Markdown
Owner Author

@codex review

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Correct slice failure-boundary coverage during branch reconciliation

🐞 Bug fix 🧪 Tests 🕐 20-40 Minutes

Grey Divider

AI Description

• Reconciles the reviewed main snapshot into dev without runtime changes.
• Tests projection-construction exceptions separately from post-projection verification failures.
• Validates failed receipts across all five projection and search slice runners.
Diagram

graph TD
  T["Integrity tests"] --> R["Slice runners"] --> P["Build projection"] --> D{"Projection succeeds?"}
  D -- No --> E["Propagate failure"]
  D -- Yes --> V["Verify behavior"] --> F["Failed receipt"] --> S["Schema validation"]
Loading
High-Level Assessment

The current approach is appropriate: inject failures at actual projection-construction and post-projection verification boundaries, then assert each boundary's real contract. Retaining the previous malformed projection-result mock would test an impossible state and obscure whether runners should propagate an exception or emit a failed receipt.

Files changed (1) +103 / -37

Tests (1) +103 / -37
test_projection_integrity_slice.pyExercise genuine slice failure boundaries +103/-37

Exercise genuine slice failure boundaries

• Replaces an impossible mocked failed projection result with explicit coverage proving projection-construction failures propagate without receipts. Adds targeted post-projection faults for five slice runners and verifies each generated failed receipt contains a failed operation and conforms to its schema.

tests/test_projection_integrity_slice.py

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-10T20:04:54.256643Z a055df8 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can turn these tips off under Display preferences

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: a055df8038

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@joefeser
joefeser merged commit c63ffe5 into dev Sep 10, 2026
6 checks passed
@joefeser
joefeser deleted the codex/reconcile-main-b5af62303a38-to-dev branch September 10, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant