Add timeline track and clip authoring - #145
Conversation
|
Review-assist pass for #10 / PR #145. I am not claiming this bounty here and I am not asking maintainers to prefer a specific submitter. Since this is a newer #10 attempt with no visible PR comments yet, I did a static acceptance pass against the issue requirements and the existing open PR queue. What looks strong:
Acceptance risks I would check before marking #10 complete:
Suggested merge bar:
This should help keep the new PR reviewable without encouraging another duplicate implementation. |
|
Fresh local validation pass for #10 / PR #145. Environment:
Result: PATH=/opt/homebrew/opt/node@22/bin:$PATH bun test packages/timeline/src/utils/timelineAuthoring.test.tsPassed: 6 tests / 18 assertions. PATH=/opt/homebrew/opt/node@22/bin:$PATH bun run --cwd packages/timeline build:declaration
PATH=/opt/homebrew/opt/node@22/bin:$PATH bun run --cwd packages/timeline buildBoth currently stop at the same TypeScript resolution error: That file is unchanged between Acceptance read after the focused test pass:
Suggested next step before close: resolve or document the |
|
Small follow-up: I opened #146 as a separate build unblocker for the It only declares |
Closes #10.
Summary
Validation
npx --yes bun run --cwd packages/clap buildnpx --yes bun test packages/timeline/src/utils/timelineAuthoring.test.tsnpx --yes bun run --cwd packages/timeline build:declarationnpx --yes bun run --cwd packages/timeline buildgit diff --check+ Trackand+ Clipcontrols were unique/clickable, a new track appeared, and no console warnings/errors were reported.