Add timeline track and clip creation controls - #141
Open
Egoistian wants to merge 1 commit into
Open
Conversation
|
Review assist for #10 / Boss bounty: I checked this diff because it is one of the still-unreviewed timeline authoring attempts. The scope is useful and focused: it adds typed track creation, typed clip creation, track-category metadata, and compatible cross-track moves without introducing another broad app rewrite. Acceptance points I would verify before choosing a canonical PR:
This looks like a plausible timeline-native base or comparison point for #10, especially if the above cases are backed by store-level tests and one browser smoke path. It should be compared against #134/#136/#139/#140/#142/#145 before merging to avoid picking overlapping implementations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClapTrack.categorymetadata and timeline store actions for creating tracks, setting empty-track categories, creating typed clips, and moving clips only to compatible tracks+ Track, category selection, and+ ClipstartTimeInMswhen adding segments and keep track occupancy in sync when clips are assignedValidation
npx --yes bun@latest run --cwd packages/clap buildnpx --yes bun@latest run --cwd packages/timeline buildgit diff --checkNotes
I could not complete
packages/app buildlocally because itspreparestep expects../../node_modules/mediainfo.js/dist/MediaInfoModule.wasm, while the local Bun install layout placed that dependency undernode_modules/.bun/.... The failure occurs before app compilation and appears unrelated to this timeline patch.