Skip to content

[SYCL RT][Coverity] Optimizing by moving instead of copy #22462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Robertkq wants to merge 4 commits into
base: sycl
Choose a base branch
from
+8 −7
Open

[SYCL RT][Coverity] Optimizing by moving instead of copy #22462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fd76988
Fix CID 490211
Robertkq Jun 27, 2026
52c45bf
Fix CID 490242
Robertkq Jun 27, 2026
b6d2885
Fix CID 490405
Robertkq Jun 27, 2026
d021dbd
Fix CID 512042 and similar cases in the same file not caught by 512042
Robertkq Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sycl/source/detail/scheduler/commands.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1321,7 +1321,7 @@ ur_result_t ReleaseCommand::enqueueImp() {
UnmapEventImpl->setHandle(UREvent);
std::swap(MAllocaCmd->MIsActive, MAllocaCmd->MLinkedAllocaCmd->MIsActive);
EventImpls.clear();
EventImpls.push_back(UnmapEventImpl);
EventImpls.push_back(std::move(UnmapEventImpl));
}
ur_event_handle_t UREvent = nullptr;
if (SkipRelease)
Expand Down
5 changes: 3 additions & 2 deletions sycl/source/detail/split_string.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,9 @@ inline std::vector<std::string> split_string(std::string_view str,
std::string LastSubStr(str.substr(Start, End - Start));
// In case str has a delimeter at the end, the substring will be empty, so
// we shouldn't add it to the final vector
if (!LastSubStr.empty())
Result.push_back(LastSubStr);
if (!LastSubStr.empty()) {
Result.push_back(std::move(LastSubStr));
}
Comment thread
uditagarwal97 marked this conversation as resolved.
}
return Result;
}
Expand Down
2 changes: 1 addition & 1 deletion sycl/source/handler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,7 +899,7 @@ void handler::ext_oneapi_barrier(const std::vector<event> &WaitList) {
if (EventImpl->isHost()) {
depends_on(EventImpl);
}
impl->MEventsWaitWithBarrier.push_back(EventImpl);
impl->MEventsWaitWithBarrier.push_back(std::move(EventImpl));
}
}

Expand Down
6 changes: 3 additions & 3 deletions sycl/source/kernel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ kernel::ext_oneapi_get_info(queue Queue, const range<1> &WorkGroupSize,
template <typename Param>
typename detail::is_kernel_queue_specific_info_desc<Param>::return_type
kernel::ext_oneapi_get_info(queue Queue, const range<3> &WG) const {
return impl->ext_oneapi_get_info<Param>(Queue, WG);
return impl->ext_oneapi_get_info<Param>(std::move(Queue), WG);
}

template <typename Param>
Expand All @@ -147,13 +147,13 @@ kernel::ext_oneapi_get_info(queue Queue, const range<2> &WorkGroupSize,
template <typename Param>
typename detail::is_kernel_queue_specific_info_desc<Param>::return_type
kernel::ext_oneapi_get_info(queue Queue, const range<2> &WG) const {
return impl->ext_oneapi_get_info<Param>(Queue, WG);
return impl->ext_oneapi_get_info<Param>(std::move(Queue), WG);
}

template <typename Param>
typename detail::is_kernel_queue_specific_info_desc<Param>::return_type
kernel::ext_oneapi_get_info(queue Queue, const range<1> &WG) const {
return impl->ext_oneapi_get_info<Param>(Queue, WG);
return impl->ext_oneapi_get_info<Param>(std::move(Queue), WG);
}

template <typename Param>
Expand Down
Loading