[SYCL RT][Coverity] Optimizing by moving instead of copy

[Robertkq]

fixes #19234

This PR addresses the following CID: 490211, 490242, 490405, 512042. All of the other CIDs that were specified by the issue #19234 have already been in the fixed state when I started working on this.

[Robertkq]

[Copilot]

Pull request overview

This PR addresses Coverity findings in the SYCL runtime by eliminating unnecessary copies and enabling move semantics when forwarding temporaries (e.g., queue, std::shared_ptr, and std::string) into implementation/storage APIs.

Changes:

• Forward queue parameters into kernel_impl::ext_oneapi_get_info via std::move for several overloads.
• Move event implementation pointers into MEventsWaitWithBarrier to avoid refcounting/copies.
• Move the final substring into the result vector in split_string to avoid an extra copy.

No control-flow changes were introduced beyond adding braces around an existing conditional; nothing here appears likely to impact profiling/debug info integrity.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
sycl/source/kernel.cpp	Move queue when delegating kernel::ext_oneapi_get_info overloads to the impl to avoid copies.
sycl/source/handler.cpp	Move EventImpl into MEventsWaitWithBarrier to avoid shared_ptr copies/refcount churn.
sycl/source/detail/split_string.hpp	Move LastSubStr into the result vector to avoid copying the last token.
sycl/source/detail/scheduler/commands.cpp	Move UnmapEventImpl into EventImpls to avoid copying shared_ptr.

[uditagarwal97]

NIT

[uditagarwal97]

Suggested change

	if (!LastSubStr.empty()) {
	Result.push_back(std::move(LastSubStr));
	}
	if (!LastSubStr.empty())
	Result.push_back(std::move(LastSubStr));

[Robertkq]

I added this as my clang-format or maybe some clangd/clang extension suggested it. I assume that it automatically read the .clang-format or related config file of the project and suggested the prefered syntax

[uditagarwal97]

I see. Which clang-format version are you using?

[Robertkq]

clang-format --version

clang-format version 22.1.8 (Fedora 22.1.8-1.fc44)

clang-tidy --version

LLVM (http://llvm.org/):
  LLVM version 22.1.8
  Optimized build.

[Robertkq]

Moved to comment from PR body:

For 512042, I found multiple cases of this missed optimization to move instead of copy in the same file, so I changed it for all. I tried to inspect the latest coverity report by file but I failed to find the correct filter / setting to use to check for existing CID for these appearances