Repository navigation
Conversation
…l paths Signed-off-by: Alexander Rybkin <alexander.rybkin@intel.com>
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s). CI at Review details
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #748 +/- ##
==========================================
- Coverage 95.73% 95.72% -0.02%
==========================================
Files 408 415 +7
Lines 54644 55346 +702
Branches 9404 9514 +110
==========================================
+ Hits 52315 52979 +664
- Misses 1439 1465 +26
- Partials 890 902 +12 🚀 New features to boost your workflow:
|
antonwolfy
left a comment
There was a problem hiding this comment.
LGTM. The rewrite removes the lab-box paths and the machine name, and what it says in their place (the data is not published, the scripts are not in the repository) agrees with the rest of the page. Nothing else in the docs links to the removed text. One nit inline.
What I ran, on a Linux review host at 2dbc367:
make ci-local: 31 passed, 1 failed, 14 skipped. The one failure isRun tests: 19,949 passed, and 2 errors that are 60 s setup timeouts intests/test_audit_test_quality.py, which the PR does not touch. That file passes alone (172 passed in 14 s), so it is load, not the PR.mkdocs build,Docs pages to review,schema_compat, mypy and the changed-line coverage step pass.
Checked, no issues
- Leftover paths: no
localdisk,napetrovpath,skill-content-intel,detpilotorlab boxremain ingrading-tiers.md. - Links: no page links to an anchor in the Prototype or Reproducing sections; every reference is to the whole page.
- Commits: the one commit carries a
Signed-off-by.
Signed-off-by: Anton Volkov <antonwolfy@gmail.com>
antonwolfy
left a comment
There was a problem hiding this comment.
LGTM. I pushed a commit per nit, up to 5edabca, which fix the nit from my review:
5edabca:dokimi/docs/grading-tiers.md:316: re-flowed the Reproducing paragraph to the suggested four lines of about 90 characters.
make ci-local at 5edabca: 32 passed, 0 failed, 14 skipped.
vchamarthi
left a comment
There was a problem hiding this comment.
Ready to merge at 5edabca: Docs-only rewrite of two passages in grading-tiers.md that removes the local paths and machine name; the text now matches the rest of the page and nothing blocks it.
Verified
- Merge: The PR merges onto current main with no conflict.
- Full suite: The full test suite passes with main merged in.
- Leftover paths:
dokimi/docs/grading-tiers.mdno longer containslocaldisk,napetrov,detpilotorlab box(grep on the head returns nothing).
Follow-up to #472.
docs/grading-tiers.mddescribed where the study data and the prototype scripts live with local paths and a machine name that a reader of the repository cannot reach. The page now says what the data is and that the scripts are not in the repository, without naming a location.Docs only; no code, test or CLI change.