Skip to content

chore(deps): limit weekly Dependabot groups to minor/patch; group the arrow stack - #223

Open
rbrenton wants to merge 1 commit into
mainfrom
chore/dependabot-minor-patch
Open

rbrenton wants to merge 1 commit into
mainfrom
chore/dependabot-minor-patch

Conversation

@rbrenton

@rbrenton rbrenton commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Why

The weekly grouped PRs from #214 put major bumps in the same PR as everything else, so a single breaking major blocks the whole batch:

Change

  • Each ecosystem's catch-all group now takes only minor and patch updates. Each major arrives as its own PR, to be handled on its own.
  • New Cargo group arrow-ecosystem (arrow*, parquet, delta_kernel, iceberg*, object_store), listed before the catch-all and covering all update types. These crates have to share one arrow major (and one object_store major), so they always move together.
  • Maven ignores:
    • org.junit.jupiter:* >=6, until the Java baseline is 17.
    • org.scala-lang:scala-library >=3.0.0. It's test-only (for S3Mock) and stays on the 2.13 line.
  • Security-update groups are unchanged. The tail of the github-actions block is untouched, so this merges cleanly alongside ci: bump the Claude reviewer by hand, to v1.0.248, and take its credential from a main-only environment #220, which appends an ignore: list there.

After this merges, close #221 and #217. Dependabot re-raises the safe updates under the new grouping and opens the majors separately.

Validation

The YAML parses (python yaml.safe_load, ruby YAML.load_file). Dependabot checks the config itself when this lands on the default branch.

…ow stack

Grouping every version update (incl. majors) into one weekly PR per ecosystem
let a single breaking major block dozens of safe updates. Grouped Cargo PR #221
bundled 40 updates and failed to compile (arrow 57->60 while parquet lagged at
59, jni 0.21->0.22, delta_kernel 0.19->0.24, iceberg 0.8->0.9); grouped Maven PR
#217 failed because junit-jupiter 5.12.2->6.1.3 needs Java 17 class files (we
target Java 11) and it also pulled scala-library 2.13.12->3.10.0.

Catch-all groups now take only minor+patch, so majors arrive as their own PRs and
can be triaged one at a time. The arrow-rs stack (arrow*, parquet, delta_kernel,
iceberg*, object_store) stays grouped across all update types because those crates
must share one arrow major (and object_store, whose types delta_kernel and iceberg
re-export, one object_store major) and break when bumped apart. Ignore junit-jupiter >=6 until the
Java baseline moves to 17, and scala-library >=3.0.0 (Scala 3 is a separate line;
test-only dep stays on 2.13.x). Security-update groups and the github-actions
block tail are untouched.
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

Automated review: PASS

Commit 9ec63a835fa2fb8d0074764a06e0180d37183912 of pull request #223 (workflow run)

Summary: The PR only changes .github/dependabot.yml. Maven, Cargo and GitHub Actions catch-all groups now take only minor and patch updates, so major bumps get their own PRs. A new arrow-ecosystem Cargo group keeps arrow, parquet, delta_kernel, iceberg and object_store moving together. Maven ignore rules hold junit-jupiter below 6 and scala-library below 3. It has no code, dependency or lock changes. The group ordering and ignore syntax look valid.

Findings (1)

  1. low .github/dependabot.yml:70 arrow-ecosystem group takes all update types, so a combined major bump of arrow/parquet/iceberg/delta_kernel can still land as one PR; the Cargo.toml tantivy/quickwit git pins are not touched by this config. This is acceptable by design, but reviewers must still check version alignment manually.

Produced from the diff alone by an automated reviewer. Text in code formatting is reviewer output shown as data. A pass is advisory: it does not replace CI or human review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant